Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop the support for value array mutations #4149

Merged
merged 2 commits into from
Jul 8, 2022
Merged

refactor: drop the support for value array mutations #4149

merged 2 commits into from
Jul 8, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jul 8, 2022 •
edited
Loading

Description

The PR drops the Polymer API that previously allowed changing the value array of checkbox-group by mutation. The value array should only support changing by reassignment.

Related to #4150

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen changed the title refactor: remove some Polymer API from checkbox-group refactor: drop the support for value array mutations Jul 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
Copy link
Member

I think this should be named refactor! and marked in release notes as behavior altering change.

@web-padawan web-padawan merged commit 1e3728b into master Jul 8, 2022
@web-padawan web-padawan deleted the refactor/checkbox-group/remove-polymer-API branch July 8, 2022 10:34
@rolfsmeds rolfsmeds mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @web-padawan