Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make grid with all rows visible respect max height #5429

Merged
merged 1 commit into from
Mar 2, 2023
Merged

fix: make grid with all rows visible respect max height #5429

merged 1 commit into from
Mar 2, 2023

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Jan 31, 2023 •
edited
Loading

Description

This change makes a <vaadin-grid> with allRowsVisible enabled to respect CSS max-height.

Fixes #2150

grid-all-rows-visible-max-height.mp4

Type of change

Bugfix

@tomivirkki tomivirkki marked this pull request as draft January 31, 2023 10:21
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki tomivirkki changed the title fix: make grid with all rows vIsible respect max height fix: make grid with all rows visible respect max height Feb 2, 2023
@tomivirkki tomivirkki marked this pull request as ready for review March 1, 2023 15:39
vursen
vursen approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@vursen vursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and it works as expected.

@tomivirkki tomivirkki merged commit 9f2e861 into main Mar 2, 2023
@tomivirkki tomivirkki deleted the fix/all-rows-visible-max-height branch March 2, 2023 16:48
@tomivirkki tomivirkki mentioned this pull request Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

@ugur-vaadin ugur-vaadin Awaiting requested review from ugur-vaadin

@yuriy-fix yuriy-fix Awaiting requested review from yuriy-fix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[grid] When using all-rows-visible grid doesn't respect max-height
2 participants
@tomivirkki @vursen