-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Register Lumo global styles before other styles #5666
Conversation
9509acb
to
dc74dd6
Compare
This ensures the styles do not override any application styles
dc74dd6
to
9f81295
Compare
Adapts the Lumo class to the changes done in vaadin/web-components#5666
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. While it is marked as fix:
actually a few files have been added.
@jouni @rolfsmeds Is this something we want to have in 24.0 or 24.1 alpha only?
There is no need for this in 24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The new modules are kind of a new feature, and could be convenient in apps don't use Flow or Hilla, but still want the Lumo theme apply to the whole page. Not sure if that requires tagging the PR differently though, it seems kind of niche.
The feature it adds would be that it allows loading all parts of Lumo in the same way, when you want everything applied globally. The ordering is much more relevant to the current issues in Flow though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor naming suggestions, and simplified DOM manipulation logic.
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Adapts the Lumo class to the changes done in vaadin/web-components#5666
Adapts the Lumo class to the changes done in vaadin/web-components#5666
Description
This ensures the styles do not override any application styles
Type of change
Checklist
Additional for
Feature
type of change