Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Register Lumo global styles before other styles #5666

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Mar 14, 2023

Description

This ensures the styles do not override any application styles

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@Artur- Artur- changed the title fix!: Register Lumo global styles in the same place in head fix!: Register Lumo global styles consecutively Mar 14, 2023
@Artur- Artur- force-pushed the register-lumo-styles-conseq branch 3 times, most recently from 9509acb to dc74dd6 Compare March 14, 2023 13:54
This ensures the styles do not override any application styles
@Artur- Artur- force-pushed the register-lumo-styles-conseq branch from dc74dd6 to 9f81295 Compare March 14, 2023 14:06
@Artur- Artur- changed the title fix!: Register Lumo global styles consecutively fix: Register Lumo global styles before other styles Mar 14, 2023
@Artur- Artur- marked this pull request as ready for review March 14, 2023 14:15
Artur- added a commit to vaadin/flow-components that referenced this pull request Mar 14, 2023
Adapts the Lumo class to the changes done in vaadin/web-components#5666
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. While it is marked as fix: actually a few files have been added.

@jouni @rolfsmeds Is this something we want to have in 24.0 or 24.1 alpha only?

@Artur-
Copy link
Member Author

Artur- commented Mar 15, 2023

There is no need for this in 24.0

Copy link
Contributor

@sissbruecker sissbruecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The new modules are kind of a new feature, and could be convenient in apps don't use Flow or Hilla, but still want the Lumo theme apply to the whole page. Not sure if that requires tagging the PR differently though, it seems kind of niche.

@Artur-
Copy link
Member Author

Artur- commented Mar 15, 2023

The feature it adds would be that it allows loading all parts of Lumo in the same way, when you want everything applied globally. The ordering is much more relevant to the current issues in Flow though

Copy link
Member

@jouni jouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor naming suggestions, and simplified DOM manipulation logic.

packages/vaadin-lumo-styles/global.js Outdated Show resolved Hide resolved
packages/vaadin-lumo-styles/color.js Outdated Show resolved Hide resolved
packages/vaadin-lumo-styles/sizing.js Outdated Show resolved Hide resolved
packages/vaadin-lumo-styles/spacing.js Outdated Show resolved Hide resolved
packages/vaadin-lumo-styles/style.js Outdated Show resolved Hide resolved
packages/vaadin-lumo-styles/typography.js Outdated Show resolved Hide resolved
packages/vaadin-lumo-styles/user-colors.js Outdated Show resolved Hide resolved
Artur- and others added 2 commits March 15, 2023 13:29
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker sissbruecker merged commit 0e72706 into main Mar 15, 2023
@sissbruecker sissbruecker deleted the register-lumo-styles-conseq branch March 15, 2023 12:00
sissbruecker pushed a commit to vaadin/flow-components that referenced this pull request Mar 16, 2023
Adapts the Lumo class to the changes done in vaadin/web-components#5666
sissbruecker pushed a commit to vaadin/flow-components that referenced this pull request Mar 16, 2023
Adapts the Lumo class to the changes done in vaadin/web-components#5666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants