[styling-base] Move logic for adding global styles from Lumo package #5680
Labels
enhancement
New feature or request
Lit
Lit conversion issue
needs discussion
No decision yet, discussion needed
refactor
Internal improvement
theme
Describe your motivation
There's a new logic added in #5666 to solve problems related to the order in which CSS applies:
web-components/packages/vaadin-lumo-styles/global.js
Lines 3 to 12 in bc227bd
While the current implementation does the job and makes sense, there are some things to improve:
@vaadin/vaadin-lumo-styles
package is a bit unexpected,document
which might be problematic for<iframe>
(embedded components etc).Describe the solution you'd like
global.js
package to other package, something like@vaadin/styling-base
,registerStyles()
for consistency,document
usage withwindow.ownerDocument
to ensure proper<iframe>
is used.The text was updated successfully, but these errors were encountered: