feat: add drag selection to grid (CP: #6243) #6543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add grid rows selection by dragging support * refactor: rename attribute column-resizing to disable-text-selection * test: add scrolling logic tests * refactor: use _selectItem and _deselectItem functions * improve scrolling tests * bind event listeners in mixin * revert column-resizing renaming * remove lasso terminology * remove unnecessary click handler * cleanup * rename API to dragSelect * cleanup tests * prevent toggling checkbox or active item after dragging on single cell * add TS definition * address review comments --------- Co-authored-by: Tomi Virkki <virkki@vaadin.com> Co-authored-by: Felipe Lang <felipe.lang@ext.vaadin.com>
yuriy-fix
force-pushed
the
feat/cp-drag-selection
branch
from
de07fe4
to
f0c4142
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Oct 4, 2023
web-padawan
added a commit
that referenced
this pull request
Nov 2, 2023
web-padawan
added a commit
that referenced
this pull request
Nov 3, 2023
|
This ticket/PR has been released with Vaadin 23.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #6243 to 23.3