Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add drag selection to grid (CP: #6243) #6543

Merged
merged 2 commits into from
Oct 4, 2023
Merged

feat: add drag selection to grid (CP: #6243) #6543

merged 2 commits into from
Oct 4, 2023

Commits on Sep 26, 2023

  1. feat: add drag selection to grid (CP: #6243) 

    * feat: add grid rows selection by dragging support

* refactor: rename attribute column-resizing to disable-text-selection

* test: add scrolling logic tests

* refactor: use _selectItem and _deselectItem functions

* improve scrolling tests

* bind event listeners in mixin

* revert column-resizing renaming

* remove lasso terminology

* remove unnecessary click handler

* cleanup

* rename API to dragSelect

* cleanup tests

* prevent toggling checkbox or active item after dragging on single cell

* add TS definition

* address review comments

---------

Co-authored-by: Tomi Virkki <virkki@vaadin.com>
Co-authored-by: Felipe Lang <felipe.lang@ext.vaadin.com>
    @sissbruecker @tomivirkki
    @flang @yuriy-fix
    3 people authored and yuriy-fix committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    16cd3b5 View commit details
    Browse the repository at this point in the history

  2. test: make getBodyCellContent helper use virtual row index (#6223)

    @sissbruecker @yuriy-fix
    sissbruecker authored and yuriy-fix committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f0c4142 View commit details
    Browse the repository at this point in the history