Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: focus editor only after it is ready (#7235) (CP: 24.3) #7291

Merged
merged 1 commit into from
Mar 29, 2024

Commits on Mar 28, 2024

  1. fix: focus editor only after it is ready (#7235)

    * fix: defer focus in order to have editor ready before
    
    * test: fix unit test for firefox
    
    * test: await next render before assertion
    
    * test: add another await next render after the first keydown
    
    * Revert "test: add another await next render after the first keydown"
    
    This reverts commit 3a62f57.
    
    * Revert "test: await next render before assertion"
    
    This reverts commit d5939d1.
    
    * test: update material visual test reference image
    
    * fix: set edit initiator char explicitly
    
    * test: revert skip test
    
    * fix: do not select input when initialized with character
    
    * Update packages/grid-pro/test/edit-column-type.common.js
    
    Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
    
    * refactor: extract input selection logic from editor focus
    
    * refactor: change name of the new property
    
    * refactor: focus lit editor once it is ready
    
    * test: revert unnecessary awaits
    
    * test: revery unnecessary test assertion changes
    
    * Revert "test: update material visual test reference image"
    
    This reverts commit f180f2b.
    
    * test: skip new test on firefox
    
    * test: revert test skip change
    
    * Update packages/grid-pro/test/edit-column-type.common.js
    
    Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
    
    ---------
    
    Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
    2 people authored and vaadin-bot committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    0a889ef View commit details
    Browse the repository at this point in the history