fix: focus editor only after it is ready (#7235) (CP: 24.3) #7291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: defer focus in order to have editor ready before * test: fix unit test for firefox * test: await next render before assertion * test: add another await next render after the first keydown * Revert "test: add another await next render after the first keydown" This reverts commit 3a62f57. * Revert "test: await next render before assertion" This reverts commit d5939d1. * test: update material visual test reference image * fix: set edit initiator char explicitly * test: revert skip test * fix: do not select input when initialized with character * Update packages/grid-pro/test/edit-column-type.common.js Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com> * refactor: extract input selection logic from editor focus * refactor: change name of the new property * refactor: focus lit editor once it is ready * test: revert unnecessary awaits * test: revery unnecessary test assertion changes * Revert "test: update material visual test reference image" This reverts commit f180f2b. * test: skip new test on firefox * test: revert test skip change * Update packages/grid-pro/test/edit-column-type.common.js Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com> --------- Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
|
web-padawan
approved these changes
Mar 29, 2024
|
This ticket/PR has been released with Vaadin 24.3.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.