Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cambodia holidays #1294

Merged
merged 27 commits into from
Jun 16, 2023
Merged

Add Cambodia holidays #1294

merged 27 commits into from
Jun 16, 2023

Conversation

PPsyrius
Copy link
Contributor

@PPsyrius PPsyrius commented Jun 7, 2023

Proposed change

Add Cambodia holidays (en_US, km, th localization).

Closes #1160.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency upgrade (version update)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@PPsyrius PPsyrius linked an issue Jun 7, 2023 that may be closed by this pull request
Add Cambodia holidays #1160
Closed
@coveralls
Copy link

coveralls commented Jun 7, 2023 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same when pulling 1cba9ae on PPsyrius:cambodia_holidays into 909278c on dr-prodigy:beta.

KJhellico
KJhellico reviewed Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just exciting! 🇰🇭 Please take a look at the small suggestions below. And I think, maybe we should create a separate class ThaiCalendarHolidays in holidays_groups?

holidays/countries/cambodia.py Outdated Show resolved Hide resolved
holidays/countries/cambodia.py Outdated Show resolved Hide resolved
@KJhellico KJhellico mentioned this pull request Jun 6, 2023
Open
KJhellico
KJhellico reviewed Jun 8, 2023
View reviewed changes
tests/countries/test_cambodia.py Outdated Show resolved Hide resolved
tests/countries/test_cambodia.py Outdated Show resolved Hide resolved
tests/countries/test_cambodia.py Outdated Show resolved Hide resolved
@PPsyrius PPsyrius requested a review from KJhellico June 9, 2023 05:25
@PPsyrius
Copy link
Contributor Author

PPsyrius commented Jun 9, 2023

Oof, forgot to check that the new normalized tuples doesn't work prior to #1296 getting merged - will revert my changes for now.

That and waiting for #1295 changes to holiday group in general before I attempt migrating _ThaiLunisolar for that since Laos will likely ended up using that too for their 10+ Buddhist holidays that are dependent on this.

@PPsyrius PPsyrius mentioned this pull request Jun 9, 2023
Merged
13 tasks
@PPsyrius
Copy link
Contributor Author

ThaiCalendarHolidays is now implemented and should hopefully simplifies future #1215 implementations down by a lot. 🙏🇹🇭🇱🇦🇰🇭

KJhellico
KJhellico reviewed Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few little suggestions

holidays/groups/thai.py Outdated Show resolved Hide resolved
holidays/groups/thai.py Outdated Show resolved Hide resolved
@PPsyrius PPsyrius requested a review from KJhellico June 12, 2023 05:21
KJhellico
KJhellico reviewed Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now 👍

@PPsyrius
Copy link
Contributor Author

Seems good now 🎉

@PPsyrius PPsyrius requested a review from KJhellico June 16, 2023 14:58
arkid15r
arkid15r reviewed Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇰🇭 LGTM

Nicely done!

holidays/countries/cambodia.py Show resolved Hide resolved
holidays/countries/cambodia.py Outdated Show resolved Hide resolved
@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label Jun 16, 2023
@PPsyrius @arkid15r
[KH] adjust comment, rerun l10n
1cba9ae 
Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
@arkid15r arkid15r merged commit 78fb6a6 into vacanza:beta Jun 16, 2023
41 checks passed
@arkid15r arkid15r removed the ready for beta Ready to merge on beta branch label Jun 16, 2023
@PPsyrius PPsyrius deleted the cambodia_holidays branch June 16, 2023 16:36
@arkid15r
Copy link
Collaborator

Hey @PPsyrius thanks for taking care of another entity.
It's great to see your persistent work on quite complicated holiday calendars!

@arkid15r arkid15r mentioned this pull request Jun 19, 2023
Merged
@arkid15r arkid15r mentioned this pull request Jul 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

@KJhellico KJhellico Awaiting requested review from KJhellico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Cambodia holidays
4 participants
@PPsyrius @coveralls @arkid15r @KJhellico