-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v.0.27 #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate Angola holidays to holiday groups * Update holidays/countries/angola.py Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * Fix all_souls_day holiday --------- Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
* [HN][group] add Columbus Day, migrate Honduras to holiday groups * [VE] migrate to Columbus Day group for Venezuela * [VE] implementing suggestions Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * [group] reorder `_add_columbus_day` alphabetically * [HN] update uk loc Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * [HN] update en_US loc Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * [HN] update testcases for forgotten l10n loc --------- Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
* Brunei holidays * Implementing Fix Suggestions Part 1 Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * Add missing `countries/__init__.py` Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> * misc. fixes * Update no. of supported countries to 123 * increments country count * Update formatting * [BN] Adapting code for #1140's changes * [BN] switch from `tr("...")` to `self.tr("...")` * [BN] forgot to run tox * oof * [BN] hopefully last fixes needed * [BN] Rearrange holidays to prevent Islamic observed duplications Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * [BN] Implementing suggestions Part 2 Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * [BN] Implementing suggestions Part 3 Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> * [BN] reformat for pre-commit's `black` compliance * [BN] fix mismatch README.rst indentation * [BN] migrate to new CustomCalendar implementation * [BN] fix mismatch README.rst indentation again * [BN] fix *estimate tag not appearing for Eid al-fitr, reorder locs * [BN] Suggestions implemented June 6th Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> * [BN] incrrement PH patch number to 0.27 --------- Co-authored-by: Arkadii Yakovets <ark@cho.red> Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
* Add Burkina Faso holidays
* [HN][group] add Columbus Day, migrate Honduras to holiday groups * [VE] migrate to Columbus Day group for Venezuela * [VE] implementing suggestions Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * [AR] movable holidays are fixed prior to 2010 * [group] reorder `_add_columbus_day` alphabetically * [group] reorder `_add_columbus_day` alphabetically * [HN] update uk loc Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * [HN] update en_US loc Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * [HN] update testcases for forgotten l10n loc * [AR] reword comment for better readability Co-authored-by: Arkadii Yakovets <ark@cho.red> --------- Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <ark@cho.red>
* [HN][group] add Columbus Day, migrate Honduras to holiday groups * [VE] migrate to Columbus Day group for Venezuela * [VE] implementing suggestions Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * [CO] migrate to holiday groups, fixes l10n discrepancies * [group] reorder `_add_columbus_day` alphabetically * [group] reorder `_add_columbus_day` alphabetically * [HN] update uk loc Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * [HN] update en_US loc Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * [HN] update testcases for forgotten l10n loc * [VE] minor l10n fixes --------- Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
* Extend HolidayBase::pop_named - Allow to pop the entire date by exact (combined) multiple holiday name - Allow to pop a single holiday by its name for a multiple holiday date * Optimize condition evaluation
* Migrate some African countries to holiday groups * Add Africa Day * Fix special holidays * Eswatini and Malawi * Mozambique
* [group] Add `_add_childrens_day_jun1(...)`` * [group] forgot these * [group] Readd `_add_childrens_day_jun1(...)` again * [group] oof * [group] implementing suggestions * [group] switch from checking constant to string Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> --------- Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
* [IM] Make Tynwald Day Movable for Isle of Man * [IM] forgot to shift Tynwald Day for 1970 * [IM] Tynwald Day only became movable in 1992 * [IM] Improve comment readability Co-authored-by: Arkadii Yakovets <ark@cho.red> --------- Co-authored-by: Arkadii Yakovets <ark@cho.red>
Naive UTC ones are deprecated as of Python 3.12.
* Refactor common:TestCase assert*HolidayName method - Retire `assertHolidaysName` method - Raise ValueError on empty test sequence * Remove the dead code * Merge w/ beta
Simplify argument passing requirements. Optimize tests execution.
* Migrate Hungary to holiday groups, localization * PR suggestion * Update tests
* Refactor _add_observed() methods * Fix UK New Year's Day (Scotland specific) * Fix Isle of Man * Remove United Kingdom from PR * PR suggestion
* Migrate Panama and Paraguay to holiday groups * Nicaragua * PR suggestion
* [KH] extend `ThaiLunisolar` for `KHMER_CALENDAR` * [KH] initial holidays implementation * [KH] add in individual holiday test cases * [KH] add in special in lieus for 2015-2023 * [KH] `en_US`. `km`, `th` l10n files * [KH] PH's coveralls back to 100% again * [KH] initial batch of suggestions Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * [KH] increments country count to 128 * [KH] refractor Cambodia testcases * [KH] remove redundant `((...),),` (see #1296) * Revert "[KH] remove redundant `((...),),` (see #1296)" This reverts commit 772e6f0. * Revert "Revert "[KH] remove redundant `((...),),` (see #1296)"" This reverts commit aabfa03. * [TH] initial `ThaiCalendarHolidays` attempt * [KH] Migrates Cambodia `_ThaiLunisolar` to holiday groups * [KH] oof, typo fixed * [group] `__verify+calender()` test for `ThaiCalendarHolidays` * [group] remove redundant checks * [KH] migrate children's day to holiday groups * [KH] turn out not all Holidays got their s removed * [KH] adjust comment, rerun l10n Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> --------- Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
* [AW] Migrate Aruba to holiday groups * [AW] implementing suggestions, improving `uk` l10n Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * [AW] Aruba l10n improvements part 2 Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * [AW] Comment changes to fit revised l10n * [AW] Standardize Papiamento/Papiamentu to `pp` As outlined in https://www.creolica.net/The-Multiple-Facets-of-Papiamentu * [AW] also update the readme * Allow using ISO 639-2 (three-letter) language codes * [AW] switch from pp to pap for Papiamento * [AW] migrate to latest testing standard * [AW] testcase name standardization Co-authored-by: Arkadii Yakovets <ark@cho.red> --------- Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <ark@cho.red>
* [CW] Migrate Curacao to holidays group * Allow using ISO 639-2 (three-letter) language codes * [CW] Fix Curacao Labour Day in-lieus Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * [CW] switch from pp to pap for Papiamento * [CW] migrate to latest testing standard * [CW] testcase name standardization --------- Co-authored-by: Arkadii Yakovets <ark@cho.red> Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
* Update .py files formatting - Increase line length limit from 79 to 99 - Change isort `multi_line_output` from 9 (Vertical Prefix From Module Import) to 3 (Vertical Hanging Indent) * Bulk replace empty " " in holidays names (73 occurrences across 27 files) * Reformat the codebase * Update l10n files * Regenerate .po files
* Update United Kingdom holidays * PR suggestion
KJhellico
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.27
Released June 19, 2023
_add_childrens_day(...)
toInternationalHolidays
(Add_add_childrens_day(...)
toInternationalHolidays
#1300 by @PPsyrius)