Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kuwait holidays #1707

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Add Kuwait holidays #1707

merged 2 commits into from
Mar 6, 2024

Conversation

arkid15r
Copy link
Collaborator

Proposed change

Resolves #1211

Add Kuwait holidays (the original code was provided by Jaemin Kim via #1705).

@jamjam0109 could you review it to when you get a chance? Thank you!

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Co-authored-by: Jaemin Kim <jamjam0109@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Feb 29, 2024

Pull Request Test Coverage Report for Build 8175678074

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 32 of 32 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8089483015: 0.0%
Covered Lines: 10628
Relevant Lines: 10628

💛 - Coveralls

@jamjam0109
Copy link
Contributor

Wow Thank you so much ! Even though I just submitted the code as an issue because I didn't know how to use Git , you applied it so quickly and effectively. I really appreciate it.

LGTM !

Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge March 6, 2024 16:50
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🇰🇼

@arkid15r arkid15r added this pull request to the merge queue Mar 6, 2024
Merged via the queue into vacanza:dev with commit b120e5e Mar 6, 2024
26 checks passed
@arkid15r arkid15r deleted the add-kw branch March 6, 2024 17:10
@arkid15r arkid15r mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kuwait holidays
4 participants