Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ukrainian translations (proper apostrophe) #1714

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Update Ukrainian translations (proper apostrophe) #1714

merged 1 commit into from
Mar 4, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update Ukrainian translations: replacing apostrophe with the proper one (ʼ, U+02BC).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@KJhellico KJhellico requested a review from arkid15r as a code owner March 2, 2024 18:53
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8124766469

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.993%
Totals Coverage Status
Change from base Build 8116782732: 0.0%
Covered Lines: 10596
Relevant Lines: 10596
💛 - Coveralls

arkid15r
arkid15r approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇺🇦 LGTM

@arkid15r arkid15r added this pull request to the merge queue Mar 4, 2024
Merged via the queue into vacanza:dev with commit d4fe4f8 Mar 4, 2024
26 checks passed
@KJhellico KJhellico deleted the fix-uk-loc branch March 4, 2024 16:55
@KJhellico KJhellico mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KJhellico @coveralls @arkid15r