Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IFEU holidays #1792

Merged
merged 6 commits into from
May 17, 2024
Merged

Add IFEU holidays #1792

merged 6 commits into from
May 17, 2024

Conversation

benjfield
Copy link
Contributor

Proposed change

I have added the base IFEU holidays which are used both for the exchange and for settlement pricing for products including Brent Futures and Low Sulphur Gasoil Futures.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented May 15, 2024

Pull Request Test Coverage Report for Build 9132506804

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9131535412: 0.0%
Covered Lines: 11190
Relevant Lines: 11190

💛 - Coveralls

@arkid15r arkid15r changed the title Feature/add ifeu Add IFEU holidays May 15, 2024
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @benjfield

Thanks for the clean code PR! I don't have much suggestions after glancing the PR.
Apparently, we need to update the supported markets section of the README.rst fle

I'll take another look later today.

Thanks again for your contribution!

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also include IFEU snapshot (see make snapshot command)?

Thank you!

tests/financial/test_ice_futures_europe.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Any suggestions @KJhellico

tests/financial/test_ice_futures_europe.py Outdated Show resolved Hide resolved
@arkid15r arkid15r enabled auto-merge May 17, 2024 18:14
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkid15r arkid15r added this pull request to the merge queue May 17, 2024
Merged via the queue into vacanza:dev with commit a5111cb May 17, 2024
29 checks passed
@arkid15r arkid15r mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants