-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IFEU holidays #1792
Add IFEU holidays #1792
Conversation
Pull Request Test Coverage Report for Build 9132506804Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @benjfield
Thanks for the clean code PR! I don't have much suggestions after glancing the PR.
Apparently, we need to update the supported markets section of the README.rst fle
I'll take another look later today.
Thanks again for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also include IFEU
snapshot (see make snapshot
command)?
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any suggestions @KJhellico
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed change
I have added the base IFEU holidays which are used both for the exchange and for settlement pricing for products including Brent Futures and Low Sulphur Gasoil Futures.
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally