Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Syntax for JSONPath #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

urmilkalaria
Copy link

Added Support for RedisJSON 2.0 full JSONPath syntax

@tinco
Copy link

tinco commented Apr 10, 2023

@urmilkalaria this merge request looks excellent! @vachhanihpavan are you still actively maintaining this Gem? If not maybe we could ask @byroot to pull it in to the main gem?

@vachhanihpavan
Copy link
Owner

@urmilkalaria this merge request looks excellent! @vachhanihpavan are you still actively maintaining this Gem? If not maybe we could ask @byroot to pull it in to the main gem?

Hi @tinco, I was waiting for replies to my comments.
I don't mind if @byroot can pull it into the main gem. I am not actively tracking updates to RedisJSON so, it'll be good if someone can take this project forward.

@byroot
Copy link

byroot commented Apr 11, 2023

I don't plan to support extensions in redis-rb, the default commands are already a very large API to maintain.

It's best to stay as a separate gem.

Additionally this one still isn't updated to work with redis-rb 5.x, and use another testing framework, so it would be a PITA to merge in.

If you don't plan to maintain this any further, what I can do is to accept it under the https://github.com/redis-rb/ org, and look for new maintainers.

@tinco
Copy link

tinco commented Apr 13, 2023

Ah I don't see any comments so I'm a bit confused.

BTW I needed the gem to work with 5.0 so I quickly updated it here: urmilkalaria/rejson-rb@master...tinco:rejson-rb:main

I only made it pass the specs. There's actually some deeper upgrades needed to match the main gem's newer API style that I didn't start on.

@vachhanihpavan
Copy link
Owner

@tinco I can transfer this project to you if you want to maintain this?

@tinco
Copy link

tinco commented Apr 13, 2023

I'm not a very dependable person at the moment. I'm using rejson for a project in my free time, my day job is super busy and I also have a baby. If I'm still using rejson in a month or two and I feel like making it more production grade I'll send you a message. At the moment I don't have the time to make something I would feel comfortable with encouraging other people to run in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants