-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{.async: (raises).}
annotations for protocols/secure
#1059
Conversation
Extend files in `libp2p/protocols/secure` with `{.async: (raises).}` annotations and also apply some minor cleanups such as removing unnecessary `result` usage, using `min` template and reordering `secio` variables to be closer to their usage, changing `var` to `let` etc. This is somewhat intertwined due to `method handshake*` which spans across all three files and must be updated in all files simultaneously.
secrets: Secret, | ||
order: int, | ||
remotePubKey: PublicKey): SecioConn | ||
{.raises: [LPError].} = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't actually raise, so use default {.raises: [].}
from top level {.push.}
.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1059 +/- ##
============================================
- Coverage 82.81% 82.56% -0.25%
============================================
Files 91 91
Lines 15750 15814 +64
============================================
+ Hits 13043 13057 +14
- Misses 2707 2757 +50
|
Extend files in
libp2p/protocols/secure
with{.async: (raises).}
annotations and also apply some minor cleanups such as removing unnecessaryresult
usage, usingmin
template and reorderingsecio
variables to be closer to their usage, changingvar
tolet
etc.This is somewhat intertwined due to
method handshake*
which spans across all three files and must be updated in all files simultaneously.