{.async: (raises).} annotations for protocols/secure
#1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend files in `libp2p/protocols/secure` with `{.async: (raises).}`
annotations and also apply some minor cleanups such as removing
unnecessary `result` usage, using `min` template and reordering `secio`
variables to be closer to their usage, changing `var` to `let` etc.
This is somewhat intertwined due to `method handshake*` which spans
across all three files and must be updated in all files simultaneously.
etan-status
commented
Mar 6, 2024
etan-status
commented
Mar 6, 2024
| secrets: Secret, | ||
| order: int, | ||
| remotePubKey: PublicKey): SecioConn | ||
| {.raises: [LPError].} = |
There was a problem hiding this comment.
it doesn't actually raise, so use default {.raises: [].} from top level {.push.}.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1059 +/- ##
============================================
- Coverage 82.81% 82.56% -0.25%
============================================
Files 91 91
Lines 15750 15814 +64
============================================
+ Hits 13043 13057 +14
- Misses 2707 2757 +50
|
arnetheduck
previously approved these changes
Mar 7, 2024
arnetheduck
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend files in
libp2p/protocols/securewith{.async: (raises).}annotations and also apply some minor cleanups such as removing unnecessaryresultusage, usingmintemplate and reorderingseciovariables to be closer to their usage, changingvartoletetc.This is somewhat intertwined due to
method handshake*which spans across all three files and must be updated in all files simultaneously.