Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New RFC Repo #1

Merged
merged 197 commits into from
Feb 8, 2024
Merged

New RFC Repo #1

merged 197 commits into from
Feb 8, 2024

Conversation

jimstir
Copy link
Collaborator

@jimstir jimstir commented Jan 26, 2024

Added Waku draft rfcs in own sub directory, separated by core, application, informational, and deprecated specification. Directory numbers should add a 0 in front of the number becuase when 100 is reached will cause older specifications to be placed at the end of a subdirectory list.

@@ -0,0 +1,409 @@
---
slug: 9
title: 9/WAKU-RPC
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be included in core directory? Also, should the file name be rpc.md(spec #16 is called rpc also, waku2-rpc.md, or waku1-rpc.md?

Comment on lines +2 to +5
slug: 24
title: 24/STATUS-CURATION
name: Status Community Directory Curation Voting using Waku v2
status: draft
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Status specs are changed to draft.

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approving so as not to be a blocker here, but I would really like to see Waku1 specs (everything prior to RFC 10) be moved to its own subfolder (waku-legacy?) or otherwise separated from Waku2.

### MembershipUpdateMessage and MembershipUpdateEvent

`MembershipUpdateEvent` is a message used to propagate information about group membership changes in a group chat.
The details are in the [Group chats specs](../56/communities.md).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this link to 56/Communities, use to be 7/GROUP-CHAT. There are a few Status specs referencing the old https://specs.status.im/.

Copy link
Contributor

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a starting point. Thank you :).
We can incrementally improve in follow up PRs.

slug: 57
title: 57/STATUS-Simple-Scaling
name: Status Simple Scaling
status: draft
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple scaling should be a raw RFC.
We could add a folder "raw" under status for now and put it there.

@@ -0,0 +1,228 @@
---
slug: 1
title: 1/COSS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note: we would have to adjust the COSS to the new process. (in a follow-up PR)

slug: 25
title: 25/LIBP2P-DNS-DISCOVERY
name: Libp2p Peer Discovery via DNS
status: deleted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would have to add this status in the COSS.
Not sure if this makes sense. Let's discuss. (This does not block this PR, just as a note)

@@ -0,0 +1,80 @@
---
slug: 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to update the numbers of the RFCs in the 2-9 range (just a note, not in this PR, please put this on the to discuss list :))

@kaiserd kaiserd merged commit 96e73ce into main Feb 8, 2024
@jimstir jimstir deleted the waku-RFC branch February 28, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants