RFC16: add version call #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ### `get_waku_v2_debug_v1_version` | ||
|
|
||
| The `get_waku_v2_debug_v1_version` method retrieves the version of a Waku v2 node as a string. | ||
| The version SHOULD follow [semantic versioning](https://semver.org/). |
There was a problem hiding this comment.
Would it make sense to specify the format of the response for the scenarios described here?
jm-clius
requested changes
May 17, 2022
content/docs/rfcs/16/README.md
Outdated
Comment on lines
104
to
105
| #### Response | ||
| - [**`WakuInfo`**](#wakuinfo) - information about a Waku v2 node |
There was a problem hiding this comment.
This section still belongs with the previous entry get_waku_v2_debug_v1_info
Could also add a simple Response subsection for this call, indicating a String response containing version / commit
content/docs/rfcs/16/README.md
Outdated
|
|
||
| none | ||
|
|
||
|
|
||
| #### Response | ||
| - [**`WakuInfo`**](#wakuinfo) - information about a Waku v2 node |
|
LGTM, also agree with comments. |
|
Feedback applied. Sorry for the delayed action. |
D4nte
reviewed
Jun 17, 2022
content/docs/rfcs/16/README.md
Outdated
| @@ -81,6 +81,10 @@ The following structured types are defined for use on the Debug API: | |||
| | `listenAddresses` | `Array`[`String`] | mandatory | Listening addresses of the node | | |||
| | `enrUri` | `String` | optional | ENR URI of the node | | |||
|
|
|||
| #### WakuInfo | |||
|
|
|||
| `Version` | |||
There was a problem hiding this comment.
Is that a typo? I am not sure to understand why this text is here.
There was a problem hiding this comment.
Yes 😅 . Removed in 1675b76
richard-ramos
approved these changes
Jun 22, 2022
kaiserd
added a commit
that referenced
this pull request
Jul 16, 2022
* master: RFC16: add version call (#505) fix(noise): update RFC to implementation (#508) fixup: 37/WAKU2-NOISE fix images paths (#506) New RFC: 37/WAKU2-NOISE-SESSIONS (#504) 36/WAKU2-BINDINGS-API (#501) docs(16/WAKU2-RPC): add ENR to waku info (#502) Adding 35/WAKU2-NOISE to menu (#500) add RFC33 to index (#499) feat: 32/RLN raw spec New RFC: 35/WAKU2-NOISE (#496) Update on the rln registration figure to match the current spec (#497) 33/WAKU-DISCV5: Add first raw version (#487) Add pubsubTopic field to index (#492) Fix markdown links (#493) Categorize 22 & 31 (#490) Changed PB Timestamp index to 10 (#491) 13/14/16/21: Change in timestamp format (#483) add: RFC31 copyright statement (#489) 17/WAKU-RLN-RELAY: Revise spec for its draft version (#484)
kaiserd
added a commit
that referenced
this pull request
Jul 25, 2022
* master: RFC16: add version call (#505) fix(noise): update RFC to implementation (#508) fixup: 37/WAKU2-NOISE fix images paths (#506) New RFC: 37/WAKU2-NOISE-SESSIONS (#504) 36/WAKU2-BINDINGS-API (#501) docs(16/WAKU2-RPC): add ENR to waku info (#502) Adding 35/WAKU2-NOISE to menu (#500) add RFC33 to index (#499) feat: 32/RLN raw spec New RFC: 35/WAKU2-NOISE (#496) Update on the rln registration figure to match the current spec (#497) 33/WAKU-DISCV5: Add first raw version (#487) Add pubsubTopic field to index (#492) Fix markdown links (#493) Categorize 22 & 31 (#490) Changed PB Timestamp index to 10 (#491) 13/14/16/21: Change in timestamp format (#483) add: RFC31 copyright statement (#489) 17/WAKU-RLN-RELAY: Revise spec for its draft version (#484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifies a debug RPC call returning a Waku node's version. This call is implemented in
nwakuaccordingly.