Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

35/WAKU2-NOISE: update RFC according to implementation #508

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

s1fr0
Copy link
Contributor

@s1fr0 s1fr0 commented Jun 14, 2022

This PR addresses #503

@oskarth oskarth added this to New in vac-research Jun 14, 2022
@oskarth oskarth moved this from New to Review/QA in vac-research Jun 14, 2022
@s1fr0 s1fr0 requested review from jm-clius and oskarth June 14, 2022 14:48
@s1fr0 s1fr0 changed the title 35/WAKU2-NOISE: update RFC to merged implementation 35/WAKU2-NOISE: update RFC according to implementation Jun 14, 2022
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1fr0 s1fr0 requested a review from staheri14 June 14, 2022 15:26
@oskarth oskarth merged commit e62934a into master Jun 15, 2022
vac-research automation moved this from Review/QA to Done Jun 15, 2022
@oskarth oskarth deleted the noise-rfc-update branch June 15, 2022 10:35
kaiserd added a commit that referenced this pull request Jul 16, 2022
* master:
  RFC16: add version call (#505)
  fix(noise): update RFC to implementation (#508)
  fixup: 37/WAKU2-NOISE fix images paths (#506)
  New RFC: 37/WAKU2-NOISE-SESSIONS (#504)
  36/WAKU2-BINDINGS-API (#501)
  docs(16/WAKU2-RPC): add ENR to waku info (#502)
  Adding 35/WAKU2-NOISE to menu (#500)
  add RFC33 to index (#499)
  feat: 32/RLN raw spec
  New RFC: 35/WAKU2-NOISE (#496)
  Update on the rln registration figure to match the current spec (#497)
  33/WAKU-DISCV5: Add first raw version (#487)
  Add pubsubTopic field to index (#492)
  Fix markdown links (#493)
  Categorize 22 & 31 (#490)
  Changed PB Timestamp index to 10 (#491)
  13/14/16/21: Change in timestamp format (#483)
  add: RFC31 copyright statement (#489)
  17/WAKU-RLN-RELAY: Revise spec for its draft version (#484)
kaiserd added a commit that referenced this pull request Jul 25, 2022
* master:
  RFC16: add version call (#505)
  fix(noise): update RFC to implementation (#508)
  fixup: 37/WAKU2-NOISE fix images paths (#506)
  New RFC: 37/WAKU2-NOISE-SESSIONS (#504)
  36/WAKU2-BINDINGS-API (#501)
  docs(16/WAKU2-RPC): add ENR to waku info (#502)
  Adding 35/WAKU2-NOISE to menu (#500)
  add RFC33 to index (#499)
  feat: 32/RLN raw spec
  New RFC: 35/WAKU2-NOISE (#496)
  Update on the rln registration figure to match the current spec (#497)
  33/WAKU-DISCV5: Add first raw version (#487)
  Add pubsubTopic field to index (#492)
  Fix markdown links (#493)
  Categorize 22 & 31 (#490)
  Changed PB Timestamp index to 10 (#491)
  13/14/16/21: Change in timestamp format (#483)
  add: RFC31 copyright statement (#489)
  17/WAKU-RLN-RELAY: Revise spec for its draft version (#484)
@s1fr0 s1fr0 added track:rfc-process RFC process track (RAD) track:waku-specs Waku specs track (RAD) and removed track:rfc-process RFC process track (RAD) labels Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track:waku-specs Waku specs track (RAD)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants