72/WAKU-RLN-KEYSTORE: add new RFC #631

jimstir · 2023-11-10T03:26:57Z

New RFC for 72/WAKU-RLN-KEYSTORE

…cs/rfcs/71/README.md

Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>

kaiserd · 2023-11-10T08:39:37Z

Thank you :). Converting this to a draft PR for now. Feel free to open it for review, once you feel it is ready for a first review round.

(Just glancing over it, I saw a few spots that do not follow sembr.)

kaiserd · 2023-11-10T08:48:21Z

@jimstir see my comment here: #629
The directory structure is mixed up.

Also, you named this document waku-keystore.md. It should be XX/README.md
As discussed, feel free to allocate the next new RFC number, and also name this PR accordingly please.
In this case, it would be 72/
Generally, just check the existing RFCs, issues and PRs, and assign the next free number.
If deemed necessary in the future, we might come up with a different number allocation process, but for now, this is the simplest and straightforward.

jimstir · 2023-11-10T17:22:47Z

@kaiserd Created this draft in the old repo and did not notice. I deleted the keystore file from the push notification repo and changed the name in this repo.

rymnc · 2024-01-04T05:51:51Z

hey @jimstir let me know if this is ready for another pass! thanks

jimstir · 2024-01-04T20:26:20Z

hey @jimstir let me know if this is ready for another pass! thanks

@rymnc I am ready for another round of feedback, thank you.

rymnc

Thanks, left a few comments

content/docs/rfcs/72/README.md

rymnc · 2024-01-05T05:33:15Z

content/docs/rfcs/72/README.md

+	IDCommitmentBigInt: buildBigIntFromUint8Array(
+        	new Uint8Array([
+          		112, 216, 27, 89, 188, 135, 203, 19, 168, 211, 117, 13, 231, 135, 229,
+          		58, 94, 20, 246, 8, 33, 65, 238, 37, 112, 97, 65, 241, 255, 93, 171,
+          		15,
+		])
+	)


Suggested change

IDCommitmentBigInt: buildBigIntFromUint8Array(

new Uint8Array([

112, 216, 27, 89, 188, 135, 203, 19, 168, 211, 117, 13, 231, 135, 229,

58, 94, 20, 246, 8, 33, 65, 238, 37, 112, 97, 65, 241, 255, 93, 171,

15,

])

)

Does the identityCredential belong in the decryption section? I recently moved it from the input section. @rymnc

its part of the input actually, it isn't used to decrypt the keystore.

@rymc Yes, I see now, so I forgot to add contractId to the membershipHash creation, which made me a little confused. I changed it to include the four attributes, instead of three previously, here and here

content/docs/rfcs/72/README.md

rymnc

Added some comments ! thanks

content/docs/rfcs/72/README.md

rymnc · 2024-01-12T05:25:58Z

content/docs/rfcs/72/README.md

@@ -202,11 +205,14 @@ Hashing function used: Poseidon Hash, as described in [Poseidon Paper](https://e

 `version`: "0.2" 

-`hash_function`: "poseidonHash"
+`hashFunction`: "poseidonHash"


does this hashFunction refer to the hash function used by the rln protocol, or by the keystore? it is necessary to differentiate between the two because we use sha256 to generate the keys for the multiple credentials in the keystore, and poseidon in the protocol which will not change anytime soon. if we do decide to move from poseidon to a different hash function, that will be reflected in the keystore version field, which we will update and ensure the rfc has the reference to it for other implementers as well.

@rymnc clarified where poseidon is being used in the test vector section. Also clarified for identity_commitment here.

rymnc

LGTM, minor changes, but looks good to merge after they have been resolved. Thanks @jimstir !!

rymnc · 2024-01-22T07:03:55Z

content/docs/rfcs/72/README.md


-The `WakuCredential` will store values used for encrytion and decrypting user's credentials.
+The `WakuCredential` will store values used for encryting and decrypting user's keystores.


Suggested change

The `WakuCredential` will store values used for encryting and decrypting user's keystores.

The `WakuCredential` will store values used for encrypting and decrypting user's keystores.

rymnc · 2024-01-22T07:04:20Z

content/docs/rfcs/72/README.md

 - it MUST be used for password verification.
- it MUST follow [EIP-2335](https://eips.ethereum.org/EIPS/eip-2335) 
+- it MUST follow [EIP-2335](https://eips.ethereum.org/EIPS/eip-2335)
+- it MAY use [SHA256](https://www.rfc-editor.org/rfc/rfc4634.txt) as the hash function


Suggested change

- it MAY use [SHA256](https://www.rfc-editor.org/rfc/rfc4634.txt) as the hash function

- it SHOULD use [SHA256](https://www.rfc-editor.org/rfc/rfc4634.txt) as the hash function to derive the `membershipHash`

rymnc · 2024-01-22T07:05:17Z

content/docs/rfcs/72/README.md


-The `contractId` SHOULD be the blockchain identifier used for `membershipcontract`.
+The `chainId` SHOULD be the blockchain identifier used for `membershipcontract`.


Suggested change

The `chainId` SHOULD be the blockchain identifier used for `membershipcontract`.

The `chainId` SHOULD be the blockchain identifier used for `membershipcontract`. It uniquely defines the chain upon which the registration has occurred.

rymnc · 2024-01-22T07:06:19Z

content/docs/rfcs/72/README.md


-The `contractId` SHOULD be the blockchain identifier used for `membershipcontract`.
+The `chainId` SHOULD be the blockchain identifier used for `membershipcontract`.
 - it MUST be a string


refer to https://github.com/ethereum/EIPs/blob/master/EIPS/eip-155.md

kaiserd

LGTM. Thanks. Ready for merge.

content/docs/rfcs/72/README.md

jimstir · 2024-03-05T15:35:21Z

Continue discussion: waku-org/specs#2. The RFC process has been changed separating raw specs and the draft/stable specs into different repositories.

jimstir and others added 23 commits October 9, 2023 12:33

Create pushNotification.md

05774a2

Update pushNotification.md

8482057

Update pushNotification.md

789da9f

Update pushNotification.md

7d6e110

Update pushNotification.md

d480749

Update pushNotification.md

54d00f4

Update and rename content/docs/rfcs/pushNotification.md to content/do…

3f98728

…cs/rfcs/71/README.md

Update README.md

56f529b

Update README.md

91bf1f9

Update README.md

e261d70

Update README.md

a59cbc0

Update content/docs/rfcs/71/README.md

ff67c9c

Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>

Update content/docs/rfcs/71/README.md

5bc2998

Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>

Update content/docs/rfcs/71/README.md

d9369aa

Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>

Update content/docs/rfcs/71/README.md

0f6b38d

Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>

Update content/docs/rfcs/71/README.md

7651f85

Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>

Update content/docs/rfcs/71/README.md

5ee2f79

Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>

Update README.md

07d8d3c

Add Status spec link

f2537fd

Removed mailserver, added some references

7ca9747

Update README.md

0ea85b8

Create waku-keystore.md

21c606a

Update waku-keystore.md

2b5003f

jimstir requested review from kaiserd and rymnc November 10, 2023 03:26

kaiserd marked this pull request as draft November 10, 2023 08:37

Update and rename

a4ce749

jimstir added 7 commits December 20, 2023 11:15

Update README.md

db2f25c

Update README.md

77ea5e4

Update README.md

e52467e

Update README.md

203db41

Update README.md

d2c59d1

Update README.md

b47509e

Update README.md

fc6e517

rymnc reviewed Jan 5, 2024

View reviewed changes

jimstir added 4 commits January 8, 2024 15:40

Update README.md

570fd0d

Update README.md

b55d7dd

Update README.md

521967f

Update README.md

c130e26

rymnc self-requested a review January 12, 2024 05:19

rymnc reviewed Jan 12, 2024

View reviewed changes

jimstir added 7 commits January 12, 2024 04:36

Update README.md

956289f

Update README.md

e4aba48

Update README.md

8af8f71

Update README.md

6636245

Update README.md

056d87b

Update README.md

67cc9dd

Update README.md

12bc8d3

rymnc approved these changes Jan 22, 2024

View reviewed changes

Update README.md

905260f

kaiserd approved these changes Feb 9, 2024

View reviewed changes

content/docs/rfcs/72/README.md Outdated Show resolved Hide resolved

Update README.md

dc64cc5

jimstir mentioned this pull request Feb 29, 2024

Add WAKU-RLN-KEYSTORE waku-org/specs#2

Open

jimstir closed this Mar 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

72/WAKU-RLN-KEYSTORE: add new RFC #631

72/WAKU-RLN-KEYSTORE: add new RFC #631

jimstir commented Nov 10, 2023 •

edited

kaiserd commented Nov 10, 2023 •

edited

kaiserd commented Nov 10, 2023

jimstir commented Nov 10, 2023 •

edited

rymnc commented Jan 4, 2024

jimstir commented Jan 4, 2024

rymnc left a comment

rymnc Jan 5, 2024

jimstir Jan 8, 2024

rymnc Jan 9, 2024

jimstir Jan 9, 2024

rymnc left a comment

rymnc Jan 12, 2024

jimstir Jan 12, 2024 •

edited

rymnc left a comment

rymnc Jan 22, 2024

rymnc Jan 22, 2024

rymnc Jan 22, 2024

rymnc Jan 22, 2024

kaiserd left a comment

jimstir commented Mar 5, 2024


		The `WakuCredential` will store values used for encrytion and decrypting user's credentials.
		The `WakuCredential` will store values used for encryting and decrypting user's keystores.

	- it MAY use [SHA256](https://www.rfc-editor.org/rfc/rfc4634.txt) as the hash function
	- it SHOULD use [SHA256](https://www.rfc-editor.org/rfc/rfc4634.txt) as the hash function to derive the `membershipHash`


		The `contractId` SHOULD be the blockchain identifier used for `membershipcontract`.
		The `chainId` SHOULD be the blockchain identifier used for `membershipcontract`.

72/WAKU-RLN-KEYSTORE: add new RFC #631

72/WAKU-RLN-KEYSTORE: add new RFC #631

Conversation

jimstir commented Nov 10, 2023 • edited

kaiserd commented Nov 10, 2023 • edited

kaiserd commented Nov 10, 2023

jimstir commented Nov 10, 2023 • edited

rymnc commented Jan 4, 2024

jimstir commented Jan 4, 2024

rymnc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rymnc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jimstir Jan 12, 2024 • edited

Choose a reason for hiding this comment

rymnc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaiserd left a comment

Choose a reason for hiding this comment

jimstir commented Mar 5, 2024

jimstir commented Nov 10, 2023 •

edited

kaiserd commented Nov 10, 2023 •

edited

jimstir commented Nov 10, 2023 •

edited

jimstir Jan 12, 2024 •

edited