-
Notifications
You must be signed in to change notification settings - Fork 15
71/STATUS-Push-Notification-Server : add new RFC #629
Conversation
…cs/rfcs/71/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first PR! 🚀
In general lgtm, certain semantic changes are required!
content/docs/rfcs/71/README.md
Outdated
mailserver | ||
> A Waku node that provides functionality to store messages permanently and deliver the messages to requesting clients. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont believe we use mailservers anymore cc: @felicio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That should be removed. We could add store nodes if that makes sense in the scope of this document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced mailserver with Waku-Store.
Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>
Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>
Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>
Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>
Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>
Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the progress so far. A few minor inline comments:
content/docs/rfcs/71/README.md
Outdated
## Push Notification Server Flow | ||
### Registration Process: | ||
|
||
![image](https://github.com/jimstir/rfc/assets/91767824/00cae4bf-6eb5-4e7b-9377-3a5d01b041a1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move this ressources to this github repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump: This ref still has to be updated. Link similar to the spec links, relative to the static website, not to github.
(You can check other RFCs for reference.)
content/docs/rfcs/71/README.md
Outdated
### Handle Errors: | ||
- If the message can’t be decrypted, the message MUST be discarded. | ||
- If `token_type` is not supported, a response MUST be sent with `error` set to `UNSUPPORTED_TOKEN_TYPE`. | ||
-If `token`, `installation_id`, `device_tokens`, `version` are empty, a response MUST be sent with `error` set to `MALFORMED_MESSAGE`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-If `token`, `installation_id`, `device_tokens`, `version` are empty, a response MUST be sent with `error` set to `MALFORMED_MESSAGE`. | |
- If `token`, `installation_id`, `device_tokens`, `version` are empty, a response MUST be sent with `error` set to `MALFORMED_MESSAGE`. |
@jimstir There seems to be a problem with the directory structure. |
Closed. Git history was messed up in this PR. |
No description provided.