-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, but will cc: @jm-clius / @Ivansete-status to approve based on store protocol specifics
As such, they are required to be *highly available* and | ||
specifically have a *high uptime* to consistently receive and store network messages. | ||
The high uptime requirement makes sure that no message is missed out hence a complete and | ||
intact view of the message history is delivered to the querying nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think high uptime is a requirement here, the waku network is meant to be slightly ephemeral in nature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct, it is specified as a SHOULD in this specification.
"Nodes willing to provide the storage service using 13/WAKU2-STORE
protocol,
SHOULD provide a complete and full view of message history."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
content/docs/rfcs/13/README.md
Outdated
Nodes running [13/WAKU2-STORE](/spec/13) SHOULD NOT store messages with the `ephemeral` flag set to `true`. | ||
|
||
## Terminology | ||
The term Personally identifiable information (PII) refers to any piece of data that can be used to uniquely identify a user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick
The term Personally identifiable information (PII) refers to any piece of data that can be used to uniquely identify a user. | |
The term Personally Identifiable Information (PII) refers to any piece of data that can be used to uniquely identify a user. |
content/docs/rfcs/13/README.md
Outdated
- `pageSize`: A positive integer indicating the number of queried `WakuMessage`s in a `HistoryQuery` (or retrieved `WakuMessage`s in a `HistoryResponse`). | ||
- `pageSize`: A positive integer indicating the number of queried `WakuMessage` in a `HistoryQuery` (or retrieved `WakuMessage` in a `HistoryResponse`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is interesting to keep the notion of possible multiple messages being retrieved, which is the usual case.
content/docs/rfcs/13/README.md
Outdated
This field maps to the `contentTopic` field of the [14/WAKU2-MESSAGE](/spec/14). | ||
|
||
### HistoryQuery | ||
|
||
RPC call to query historical messages. | ||
|
||
- The `pubsubTopic` field MUST indicate the pubsub topic of the historical messages to be retrieved. | ||
This field denotes the pubsub topic on which waku messages are published. | ||
This field denotes the pubsub topic on which Waku messages are published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field denotes the pubsub topic on which Waku messages are published. | |
This field denotes the pubsub topic on which `WakuMessage`s are published. |
* Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md
* Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md
Updating links and format.