13/WAKU2-STORE: Update #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
reviewed
Jan 12, 2024
There was a problem hiding this comment.
LGTM in general, but will cc: @jm-clius / @Ivansete-status to approve based on store protocol specifics
Comment on lines
+31
to
+34
| As such, they are required to be *highly available* and | ||
| specifically have a *high uptime* to consistently receive and store network messages. | ||
| The high uptime requirement makes sure that no message is missed out hence a complete and | ||
| intact view of the message history is delivered to the querying nodes. |
There was a problem hiding this comment.
I don't think high uptime is a requirement here, the waku network is meant to be slightly ephemeral in nature.
There was a problem hiding this comment.
This is correct, it is specified as a SHOULD in this specification.
"Nodes willing to provide the storage service using 13/WAKU2-STORE protocol,
SHOULD provide a complete and full view of message history."
Ivansete-status
approved these changes
Jan 12, 2024
content/docs/rfcs/13/README.md
Outdated
| Nodes running [13/WAKU2-STORE](/spec/13) SHOULD NOT store messages with the `ephemeral` flag set to `true`. | ||
|
|
||
| ## Terminology | ||
| The term Personally identifiable information (PII) refers to any piece of data that can be used to uniquely identify a user. |
There was a problem hiding this comment.
Minor nitpick
Suggested change
| The term Personally identifiable information (PII) refers to any piece of data that can be used to uniquely identify a user. | |
| The term Personally Identifiable Information (PII) refers to any piece of data that can be used to uniquely identify a user. |
content/docs/rfcs/13/README.md
Outdated
Comment on lines
118
to
126
| - `pageSize`: A positive integer indicating the number of queried `WakuMessage`s in a `HistoryQuery` (or retrieved `WakuMessage`s in a `HistoryResponse`). | ||
| - `pageSize`: A positive integer indicating the number of queried `WakuMessage` in a `HistoryQuery` (or retrieved `WakuMessage` in a `HistoryResponse`). |
There was a problem hiding this comment.
I think is interesting to keep the notion of possible multiple messages being retrieved, which is the usual case.
content/docs/rfcs/13/README.md
Outdated
| This field maps to the `contentTopic` field of the [14/WAKU2-MESSAGE](/spec/14). | ||
|
|
||
| ### HistoryQuery | ||
|
|
||
| RPC call to query historical messages. | ||
|
|
||
| - The `pubsubTopic` field MUST indicate the pubsub topic of the historical messages to be retrieved. | ||
| This field denotes the pubsub topic on which waku messages are published. | ||
| This field denotes the pubsub topic on which Waku messages are published. |
There was a problem hiding this comment.
Suggested change
| This field denotes the pubsub topic on which Waku messages are published. | |
| This field denotes the pubsub topic on which `WakuMessage`s are published. |
s-tikhomirov
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md
s-tikhomirov
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating links and format.