chore(rln): add verifying key deser benchmark #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 2e39249Click to view benchmark
|
Benchmark for 2e39249Click to view benchmark
|
seemenkina
reviewed
Jun 7, 2024
seemenkina
reviewed
Jun 7, 2024
| }) | ||
| } | ||
|
|
||
| // Computes the verification key from its JSON serialization | ||
| fn vk_from_json(vk: &str) -> Result<VerifyingKey<Curve>> { | ||
| let json: Value = serde_json::from_str(vk)?; | ||
| to_verifying_key(json) | ||
| to_verifying_key(&json) | ||
| } | ||
|
|
||
| // Computes the verification key from a bytes vector containing its JSON serialization | ||
| fn vk_from_vector(vk: &[u8]) -> Result<VerifyingKey<Curve>> { |
There was a problem hiding this comment.
Here we don't need to serialise into json at all if we will use ark deserialise
seemenkina
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarking deserialization of verifying key. Need to merge this before #257 to check if performance gains are being made.