Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(rln): use unchecked for Projective instantiation [dont merge] #257

Closed
wants to merge 1 commit into from

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Jun 6, 2024

No description provided.

Copy link

github-actions bot commented Jun 6, 2024

Benchmark for 55ae0e1

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 848.5±41.49ns 850.3±7.47ns +0.21%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::get_empty_leaves_indices 7.4±0.10ns 7.5±0.15ns +1.35%
FullMerkleTree::get_subtree_root 0.9±0.01ns 0.9±0.01ns 0.00%
FullMerkleTree::override_range 1305.7±15.17ns 1301.1±18.24ns -0.35%
FullMerkleTree::set 845.3±9.98ns 847.7±7.77ns +0.28%
OptimalMerkleTree::compute_root 1020.2±15.38ns 1011.4±15.48ns -0.86%
OptimalMerkleTree::delete 1022.2±10.66ns 1009.5±14.11ns -1.24%
OptimalMerkleTree::get 23.7±0.26ns 23.5±0.28ns -0.84%
OptimalMerkleTree::get_empty_leaves_indices 7.1±0.10ns 7.1±0.20ns 0.00%
OptimalMerkleTree::get_subtree_root 24.3±0.20ns 23.6±0.27ns -2.88%
OptimalMerkleTree::override_range 4.2±0.04µs 4.2±0.07µs 0.00%
OptimalMerkleTree::set 1023.7±13.17ns 1018.5±28.11ns -0.51%

Copy link

github-actions bot commented Jun 6, 2024

Benchmark for 55ae0e1

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.3±0.39ms 14.7±0.16ms +2.80%
OptimalMerkleTree::::full_height_gen 581.1±14.61µs 567.9±4.50µs -2.27%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 326.4±6.77ns 335.8±5.20ns +2.88%
Pmtree::get_empty_leaves_indices 8.4±0.16ns 8.4±0.12ns 0.00%
Pmtree::get_subtree_root 474.2±8.68ns 478.9±8.81ns +0.99%
Pmtree::override_range 238.9±5.87µs 242.8±7.08µs +1.63%
Pmtree::set 54.6±0.36µs 54.1±1.72µs -0.92%
Pmtree:delete 54.5±0.52µs 54.1±0.65µs -0.73%
Set/FullMerkleTree::::set/1 552.9±3.02µs 544.6±6.94µs -1.50%
Set/FullMerkleTree::::set/10 5.6±0.01ms 5.4±0.02ms -3.57%
Set/FullMerkleTree::::set/100 55.6±0.32ms 54.9±0.22ms -1.26%
Set/FullMerkleTree::::set_range/1 552.6±5.80µs 543.3±5.72µs -1.68%
Set/FullMerkleTree::::set_range/10 759.5±5.19µs 748.3±33.71µs -1.47%
Set/FullMerkleTree::::set_range/100 3.3±0.00ms 3.3±0.02ms 0.00%
Set/OptimalMerkleTree::::set/1 558.2±3.53µs 548.2±3.14µs -1.79%
Set/OptimalMerkleTree::::set/10 5.6±0.03ms 5.5±0.02ms -1.79%
Set/OptimalMerkleTree::::set/100 56.1±0.30ms 55.1±0.23ms -1.78%
Set/OptimalMerkleTree::::set_range/1 556.9±3.44µs 545.7±11.89µs -2.01%
Set/OptimalMerkleTree::::set_range/10 5.6±0.02ms 5.5±0.02ms -1.79%
Set/OptimalMerkleTree::::set_range/100 56.0±0.18ms 54.7±0.25ms -2.32%
zkey::upload_from_folder 3.3±0.00s 3.3±0.01s 0.00%

@rymnc
Copy link
Contributor Author

rymnc commented Jun 14, 2024

closing in favor of #259

@rymnc rymnc closed this Jun 14, 2024
@rymnc rymnc deleted the bench-unchecked branch June 14, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant