chore(rln): use ark serialized verification key for faster serde #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 46b1959Click to view benchmark
|
Benchmark for 9ce478bClick to view benchmark
|
Benchmark for 46b1959Click to view benchmark
|
Benchmark for 9ce478bClick to view benchmark
|
rymnc
commented
Jun 13, 2024
| use std::path::Path; | ||
|
|
||
| // Here we benchmark how long the deserialization of the | ||
| // verifying_key takes, only testing the json => verifying_key conversion, | ||
| // and skipping conversion from bytes => string => serde_json::Value | ||
| pub fn vk_deserialize_benchmark(c: &mut Criterion) { | ||
| let vk = RESOURCES_DIR.get_file(Path::new(VK_FILENAME)).unwrap(); | ||
| let vk = vk.contents_utf8().unwrap(); | ||
| let json: Value = serde_json::from_str(vk).unwrap(); | ||
| let vk = vk.contents(); | ||
|
|
||
| c.bench_function("circuit::to_verifying_key", |b| { |
There was a problem hiding this comment.
leaving the bench_function name as-is to compare. will fix in following PR
Benchmark for 9380d29Click to view benchmark
|
seemenkina
approved these changes
Jun 13, 2024
rln/src/circuit.rs
Outdated
| to_verifying_key(&json) | ||
| // Computes the verification key from a bytes vector containing pre-processed ark-serialized verification key | ||
| // uncompressed, unchecked | ||
| pub fn vk_from_slice(data: &[u8]) -> Result<VerifyingKey<Curve>> { |
There was a problem hiding this comment.
maybe we need other function name? Like vk_from_ark_serilized or vk_from_ark_json
because I was expecting something along the lines of what we did when we pulled specific bytes from the slice
Benchmark for 9380d29Click to view benchmark
|
Benchmark for 0138fdbClick to view benchmark
|
Benchmark for 0138fdbClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-processed the verification key in a similar manner to
rln_final.arkzkey, and replaced the verification_key.json with it, and all references to it