-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade for Ink 3 #25
Conversation
package.json
Outdated
@@ -7,7 +7,7 @@ | |||
"author": { | |||
"name": "Vadim Demedes", | |||
"email": "vdemedes@gmail.com", | |||
"url": "github.com/vadimdemedes" | |||
"url": "https://github.com/vadimdemedes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you undo this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 35ef418.
src/SelectInput.js
Outdated
</StdinContext.Consumer> | ||
); | ||
} | ||
const SelectInputWithStdin = props => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this component and use useStdin
hook from inside <SelectInput>
itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in bc8a16a. I've never used a hook in a class before 😲. Can you get away with this because it's a PureComponent?
Thanks for doing this! Tests are failing, because you're using latest AVA, but config is for the old version. Could you update AVA's config to support Babel? Instructions are here -> https://github.com/avajs/babel. |
Hey @kellymears, do you think you'll be able to finish this PR? Totally cool if not. |
I have some time tomorrow and I’d love to finish it. Sorry for the delay and thanks x infinity for the rad framework! |
There are actually two issues here, from what I can tell: 1. Error: Error while loading rule '@typescript-eslint/await-thenable': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser.
Occurred while linting /Users/kellymears/code/projects/cli/bud/ink-select-input/index.d.ts
... This was brought up in April xojs/xo#450. However, it was already fixed by this PR: xojs/xo#452. So, I'm not sure what I'm doing wrong. 2. I tried to fix the first error (related to the Sorry that this isn't in the bag. I didn't realize that upgrading the ava/xo deps was going to turn into such a thing or I would have tread a little more carefully. |
No worries, thanks for investing the time into it! I submitted #27, which is based on this PR and fixes the tests and a bunch of other things ;) |
This updates the component to work with Ink 3.
I couldn't get the tests to pass and I'm really not very familiar with typescript.. but the component is working in my project as expected.