Fix arrow and page up/down keys detected as meta keys (#573)

vadimdemedes · Mar 28, 2023 · 09261d5 · 09261d5
1 parent 71770f8
commit 09261d5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/src/hooks/use-input.ts b/src/hooks/use-input.ts
@@ -164,7 +164,15 @@ const useInput = (inputHandler: Handler, options: Options = {}) => {
 				key.ctrl = true;
 			}
 
-			if (input.startsWith('\u001B')) {
+			if (
+				input.startsWith('\u001B') &&
+				!key.upArrow &&
+				!key.downArrow &&
+				!key.leftArrow &&
+				!key.rightArrow &&
+				!key.pageUp &&
+				!key.pageDown
+			) {
 				input = input.slice(1);
 				key.meta = true;
 			}

diff --git a/test/fixtures/use-input.tsx b/test/fixtures/use-input.tsx
@@ -31,32 +31,32 @@ function UserInput({test}: {test: string | undefined}) {
 			return;
 		}
 
-		if (test === 'upArrow' && key.upArrow) {
+		if (test === 'upArrow' && key.upArrow && !key.meta) {
 			exit();
 			return;
 		}
 
-		if (test === 'downArrow' && key.downArrow) {
+		if (test === 'downArrow' && key.downArrow && !key.meta) {
 			exit();
 			return;
 		}
 
-		if (test === 'leftArrow' && key.leftArrow) {
+		if (test === 'leftArrow' && key.leftArrow && !key.meta) {
 			exit();
 			return;
 		}
 
-		if (test === 'rightArrow' && key.rightArrow) {
+		if (test === 'rightArrow' && key.rightArrow && !key.meta) {
 			exit();
 			return;
 		}
 
-		if (test === 'pageDown' && key.pageDown) {
+		if (test === 'pageDown' && key.pageDown && !key.meta) {
 			exit();
 			return;
 		}
 
-		if (test === 'pageUp' && key.pageUp) {
+		if (test === 'pageUp' && key.pageUp && !key.meta) {
 			exit();
 			return;
 		}