-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
what to do when a view gets longer than the screen as it flickers badly on updates #359
Comments
Hm, not really, this is up to your terminal to render the text, so the flickering is on them. For example, while iTerm may flicker, built-in terminal app in macOS almost never does. As for the code here, what is the UI supposed to do? I will probably be able to help better if I'm more familiar with your use case. |
We noticed in our app (gitgud) that iTerm2 would cause it to become almost unusable due to flickering. If you switch terminals to hyper or the default mac terminal it will almost completely fix the issue. I think it is just an iTerm2 bug. |
FWIW, I feel like lately iTerm2 has been having issues like this that are definitely unrelated to Ink. Just streaming significant of output in general has been weird. Maybe the most recent update had a bug or something? |
Hello, I'm having issues running my application in "fullscreen" on iTerm. The screen is flickering really badly when there are a lot of updates to the screen. It seems as iTerm queues up all the frames and shows them one by one instead of just showing the latest frame. My application is a circle-ci dashboard. I was inspired by k9s (https://github.com/derailed/k9s) which runs really smoothly on iTerm (written in go though). Have a look at my project to see if you can find any gotchas: |
It seems to be an iTerm issue. Try using a different terminal. |
Yes, it's definitely an iTerm issue, however, if I were to distribute my cli I want it to run smoothly in every terminal. Since there are applications running smoothly on iTerm (k9s as an example), I guess there are some hacks/features ink can implement in order to make the iTerm experience better |
The changes in the linked PR drastically improves the flickering in iTerm for me. Although I needed to make the box height 1 less than |
Just chiming in to say that I had the same problem on Windows, and @royshouvik 's solution worked for me as well for Windows Terminal both cmd and PowerShell. Thank you for the tip! |
Is there plans to still merge the POC or something more polished (if needed)? |
Is there any easy way to detect when this is happening so we can take corrective measures?
The text was updated successfully, but these errors were encountered: