Throw when component is missing #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this be an error, rather than a warning? Otherwise the previous |
|
@vadimdemedes fixed. |
vadimdemedes
requested changes
Jul 9, 2017
lib/h.js
Outdated
| @@ -4,6 +4,10 @@ const flatten = require('lodash.flattendeep'); | |||
| const VNode = require('./vnode'); | |||
|
|
|||
| module.exports = (component, props, ...children) => { | |||
| if (typeof component !== 'function' && typeof component !== 'string') { | |||
| throw new TypeError(`ink.h: expected component to be a function, but received "${component}". You may have forgotten to export a component.`); | |||
There was a problem hiding this comment.
Could you remove ink.h and start with Expected?
Also, replace "${component}" with typeof component.
test/h.js
Outdated
| @@ -163,3 +163,10 @@ test.failing('don\'t merge children of components', t => { | |||
|
|
|||
| t.deepEqual(node.props.children, ['x', 'y']); | |||
| }); | |||
|
|
|||
| test('warns on invalid type', t => { | |||
| t.throws(() => { | |||
There was a problem hiding this comment.
=> t.throws(() => h(), 'Expected component to be a function, got undefined. You may have forgotten to export a component.');
test/h.js
Outdated
| @@ -163,3 +163,10 @@ test.failing('don\'t merge children of components', t => { | |||
|
|
|||
| t.deepEqual(node.props.children, ['x', 'y']); | |||
| }); | |||
|
|
|||
| test('warns on invalid type', t => { | |||
There was a problem hiding this comment.
warns => throws
invalid type => missing component
vadimdemedes
changed the title
vadimdemedes
approved these changes
Jul 9, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React has a similar warning. Ran into it when working on #3