String features for use with Apache Arrow v3.0 #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like trim has two bugs, it doesn't take the TrimOptions for ascii kernels, and the tests fail. I'll open a PR to expose them later, and we can file an issue at the Arrow JIRA. |
|
Closes #537 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should support the string features that are ported to Apache Arrow v3, which should be released soon
[ ] trim ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim聽apache/arrow#8621whereusing fillna/take since that is also quite slow on strings now