ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string]) #8628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
commented
Nov 10, 2020
| KERNEL_RETURN_IF_ERROR( | ||
| ctx, builder.ReserveData(input.buffers[2]->size() + | ||
| fill_value.length() * input.GetNullCount())); | ||
| KERNEL_RETURN_IF_ERROR(ctx, builder.Resize(input.length + 1)); |
There was a problem hiding this comment.
I accidentally forgot the +1 here, and everything worked. Does CI include valgrind, and should it pick this up?
There was a problem hiding this comment.
The +1 should not be necessary. This is the number of values appended, not the number of offsets.
pitrou
reviewed
Nov 10, 2020
pitrou
reviewed
Nov 10, 2020
|
Looking at the implementation of |
pitrou
reviewed
Nov 12, 2020
| // null count 0 unless we explicitly propagate it below. | ||
| DCHECK(output->buffers[0] == nullptr); | ||
|
|
||
| if (input.MayHaveNulls() && fill_value_scalar.is_valid) { |
There was a problem hiding this comment.
Instead of calling MayHaveNulls, just compute the null count and check it here.
|
@pitrou i think this is ready to go/review. |
…ng], scalar[string])
pitrou
approved these changes
Nov 16, 2020
5 tasks
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…ng], scalar[string]) Closes apache#8628 from maartenbreddels/ARROW-9489 Lead-authored-by: Maarten A. Breddels <maartenbreddels@gmail.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.