-
Notifications
You must be signed in to change notification settings - Fork 78
Issue #211 Making DNS host configuration a Vagrant host capabiltiy #218
Conversation
… host capabiltiy - Moving guest capabilities into dedicated folder to create namespace for upcoming host capabilities - Restructuring tests and making ResolverConfig a host capability - host_redirect_dns option
@budhrg @LalatenduMohanty @bexelbie - here is the pull request for automatic configuration of DNS on "known" Linux system. The overall change seems big, but that is mainly due to the fact that I did a quite big refactoring to make host DNS configuration a Vagrant host capability. Any feeback? Otherwise I'll go ahead and cut a 1.1.0.beta.2. |
@@ -177,7 +177,12 @@ through the host's VPN connection). | |||
### Visibility on the Host | |||
|
|||
Visibility on the host means that the hostname of the VMs can be resolved on the host's DNS system. | |||
Depending on the OS this might require some manual configuration. | |||
Landrush will attempt an automatic configuration of the host, but depending on the OS manual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need comma after the OS
word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@hferentschik +1 for configuring DNS as per host capability. |
def install_dnsmasq(_env) | ||
system('sudo yum clean all > /dev/null 2>&1') | ||
system('sudo yum install -y -q dnsmasq > /dev/null 2>&1') | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Fedora we should use dnf. So we should add another host capability as Fedora which Vagrant provides us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to accept a pull request :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vagrant does not provide host type check for Fedora out of the box. It does hardly for any OS. That's the reason why I had my own XYZHost classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hferentschik checked Vagrant's code and you are right. I do not see code for Fedora in vagrant/plugins/hosts . This is crazy :( . I was assuming like guest Vagrant would have support for Fedora host.
@hferentschik Which Linux distribution you have used to test the PR. |
Also I do not see any documentation with the PR? or did I miss it? |
Yeah, makes the code more uniform and easy to add new host types
Debian, Ubuntu, CentOS
I think you did. Check the changes to the README |
…ost visibility on Linux - Adding host detection for Debian and Ubuntu (Red Hat provided by Vagrant)
… to run sudo commands
No description provided.