Add vcpupin support #1007
Merged
Add vcpupin support #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Locally, when I attempt to test, I get the following error: $ bundle exec vagrant up --provider=libvirt
You appear to be running Vagrant outside of the official installers.
Note that the installers are what ensure that Vagrant has all required
dependencies, and Vagrant assumes that these dependencies exist. By
running outside of the installer environment, Vagrant may not function
properly. To remove this warning, install Vagrant using one of the
official packages from vagrantup.com.
Bringing machine 'test_vm_test' up with 'libvirt' provider...
There are errors in the configuration of this machine. Please fix
the following errors and try again:
Libvirt Provider:
* The following settings shouldn't exist: cpuaffinity |
README.md
Outdated
| Vagrant.configure("2") do |config| | ||
| config.vm.provider :libvirt do |libvirt| | ||
| libvirt.cpus = 4 | ||
| libvirt.cpuaffinitiy |
There was a problem hiding this comment.
Typo using cpuaffinity here, but cpu_affinity for the config option below. Guessing that is the source of the failure you were seeing testing locally?
|
@mark-i-m if you're working on this PR anymore I'd be interested to finish it up |
|
@acidghost Please do! I unfortunately no longer have the time :/ @electrofelix Thanks for creating this project. It's a useful tool. I wish I had time to work on it. |
|
Download the latest artifacts for this pull request here: |
|
Pull Request Test Coverage Report for Build 3209997547
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3210030043
💛 - Coveralls |
|
Maintainers: This PR updates the documentation, please review and apply |
mmguero
pushed a commit
to mmguero-dev/vagrant-libvirt
that referenced
this pull request
Oct 10, 2022
Support tuning to pin which host CPUs the vCPUs will be pinned to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.