Add random hostname option

[nicot]

Let the user add information to the hostname from their Vagrantfile.

When on, prevent domain name collisions.

Off by default.

Fixes #215

[sciurus]

As this point domain_name is just the prefix, which is shared between all VMs in the Vagrantfile. After the gsub, you need

domain_name << '_'
domain_name << env[:machine].name.to_s

to add the individual machine's name.

[bradleyd]

This looks good. Add this to readme??

[sciurus]

As this point domain_name is just the prefix, which is shared between all VMs in the Vagrantfile. Before appending the random string, you need

domain_name << '_'
domain_name << env[:machine].name.to_s

to add the individual machine's name.

[sciurus]

Thanks for working on this, but I'm confused exactly what values you're intending to use in the name. Here's what I was expecting

prefix = config.default_prefix ? config.default_prefix.to_s : env[:root_path].basename.to_s
machine_name = env[:machine].name.to_s
postfix = config.random_hostname ? "_#{Time.now.utc.to_i}_#{SecureRandom.hex(10)}" : ''

domain_name = "#{prefix}_#{machine_name}#{postfix}

[nicot]

@sciurus @purpleidea Is this what you had in mind?

[sciurus]

Thanks @nicot ; name generation now looks good to me!

I think you'll need to update the "builds simple domain name test" case.

[purpleidea]

@nicot didn't test, but this looks good :)

Assuming this passes the tests, +1

Thanks!

[pronix]

add please description to README

[sciurus]

@nicot What I meant by updating the simple name test was something like this

 describe VagrantPlugins::ProviderLibvirt::Action::SetNameOfDomain do
   before :each do
     @env = EnvironmentHelper.new
+    @env.name = 'name'
   end

   it "builds unique domain name" do
@@ -16,6 +17,6 @@ describe VagrantPlugins::ProviderLibvirt::Action::SetNameOfDomain do
   it "builds simple domain name" do
     @env.default_prefix= 'pre'
     dmn = VagrantPlugins::ProviderLibvirt::Action::SetNameOfDomain.new(Object.new, @env)
-    dmn.build_domain_name(@env).should eq('pre_') 
+    dmn.build_domain_name(@env).should eq('pre_name')
   end
 end

so we test that the VM's name is incorporated in the domain name.

[purpleidea]

@pronix @sciurus Shouldn't this be merged by now :P
My machine error-ed today with: "Too many random characters generated for VM's"...

[sciurus]

I'm fine with merging this and then fixing up the tests, since I haven't heard from @nicot in a couple weeks.

[sciurus]

@pronix can you please merge this and cut a release?

[nicot]

@sciurus I no longer have an environment where I can test these changes, so if you or anyone else wanted to take that over I'd appreciate it.

[sciurus]

Thanks everyone!