Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pimcore 11 #19

Merged
merged 10 commits into from
Dec 27, 2023
Merged

Pimcore 11 #19

merged 10 commits into from
Dec 27, 2023

Conversation

limenet
Copy link
Member

@limenet limenet commented Oct 5, 2023

No description provided.

@limenet limenet self-assigned this Oct 5, 2023
pryserv
pryserv approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@pryserv pryserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests carried out based on a current Pimcore v11.0 project -> so far no problems have been identified 👍

Approved -> as no critical problems were identified

src/Controller/FormController.php Outdated Show resolved Hide resolved
src/Controller/FormController.php Show resolved Hide resolved
src/Document/Areabrick/Form.php Outdated Show resolved Hide resolved
src/Form/Builder.php Outdated Show resolved Hide resolved
src/Form/FormErrorNormalizer.php Show resolved Hide resolved
@limenet limenet marked this pull request as ready for review December 27, 2023 11:43
@limenet limenet mentioned this pull request Dec 27, 2023
Closed
@limenet limenet requested a review from pryserv December 27, 2023 13:09
pryserv
pryserv approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@pryserv pryserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional tests:

  • Install/Unistall -> OK
  • Configurable mail document -> OK

src/Controller/FormController.php Outdated Show resolved Hide resolved
@limenet limenet force-pushed the pimcore-11 branch 2 times, most recently from 0b653fc to c356880 Compare December 27, 2023 14:41
@limenet limenet merged commit 04d864a into main Dec 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pryserv pryserv pryserv approved these changes

Assignees

@limenet limenet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limenet @pryserv