Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 support #62

Merged
merged 5 commits into from
Mar 9, 2023
Merged

Conversation

inverse
Copy link
Collaborator

@inverse inverse commented Jan 2, 2023

Proposed change

Add Python 3.11 support

How to test the change

Checklist

  • Tests have been added to verify that the new code works (if possible)
  • Documentation has been updated to reflect changes
  • Changelog has been updated to reflect changes

@inverse inverse mentioned this pull request Jan 2, 2023
3 tasks
@inverse inverse requested a review from valayDave January 2, 2023 20:24
@valayDave
Copy link
Owner

@inverse This Looks good, but the tests seem to have discovered a bug in 3.11. Can you check that?

@inverse
Copy link
Collaborator Author

inverse commented Mar 8, 2023

@valayDave yup! there was a lot of deprecated warnings on Python 3.10

 DeprecationWarning: Flags not at the start of the expression

So I modified the rules to make the ones complaining case insensitive throughout - do you think that'll be an issue? Only thing I can see is potentially more false positives but I don't think it'll be an issue.

@inverse inverse changed the title Add Python 3.11 to matrix Add Python 3.11 support Mar 8, 2023
@valayDave
Copy link
Owner

Logically identical so problems at all!

@inverse inverse merged commit 25dfa9d into valayDave:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants