Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy pre-commit #64

Merged
merged 5 commits into from
Mar 8, 2023
Merged

Tidy pre-commit #64

merged 5 commits into from
Mar 8, 2023

Conversation

inverse
Copy link
Collaborator

@inverse inverse commented Jan 2, 2023 •
edited

Proposed change

  • Use pre-commit action
  • Drop pre-commit dev dependencies from poetry managed
  • Bump pre-commit framework + fix broken flake8

Should be merged after #62

How to test the change

Checklist

  • Tests have been added to verify that the new code works (if possible)
  • Documentation has been updated to reflect changes
  • Changelog has been updated to reflect changes

@inverse inverse requested a review from valayDave January 2, 2023 20:24
@inverse
Copy link
Collaborator Author

inverse commented Mar 8, 2023

@valayDave any feedback for this + the other PRs?

@inverse inverse merged commit c91ff1f into valayDave:master Mar 8, 2023
@inverse inverse deleted the fix-lint branch March 8, 2023 17:50
@inverse
Copy link
Collaborator Author

inverse commented Mar 8, 2023

Finally fixed 👾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valayDave valayDave valayDave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inverse @valayDave