fix: handler delay not being respected #49
Conversation
| await page.goto('/users'); | ||
|
|
||
| // wait a little bit just to make sure DOM has had time to update | ||
| await page.waitForTimeout(10); |
There was a problem hiding this comment.
Maybe one of the waitUntil option on page.goto would suffice?
There was a problem hiding this comment.
Awesome, I didn't know about this. I've updated the test to use it :)
|
Very nice! Thank you! I will try it out tomorrow! :) |
|
Just tested it in my codebase :) Works just as expected :D Thank you! |
|
Awesome, thanks @SetupCoding. I'll get this merged and released shortly! |
Hi @valendres How can we help you to release this fix to NPM repo? :) |
|
My apologies for the delay @gejgalis (and @SetupCoding). A simple nudge should be sufficient. In all honesty, the reason why this has not been released is because I identified that the tests for this feature were flaky shortly after mentioning it, but did not get around to identifying why. I (regrettably) forgot about it. Normally i'd be a bit more attentive, but i've just been really busy of late with getting life sorted after relocating from Australia to the US 😥 Anyway - I plan to spend some time today to fix these flaky tests, but if you're willing to help resolve them, that might speed things along :) Regardless, thank you for reminding me! |
|
@valendres no worries! |
|
A fix for this has been released in playwright-msw@2.2.0 |
@SetupCoding this PR should address #45