-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handler delay not being respected #49
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
import { expect, test } from '../test'; | ||
import { rest } from 'msw'; | ||
|
||
test.describe.parallel('delay', () => { | ||
test('should send mock response after specified delay in the handler', async ({ | ||
page, | ||
worker, | ||
}) => { | ||
await worker.use( | ||
rest.get('/api/users', (_, response, context) => | ||
response( | ||
context.delay(500), | ||
context.json([ | ||
{ | ||
id: 'fake', | ||
firstName: 'Delayed', | ||
lastName: 'Response', | ||
}, | ||
]) | ||
) | ||
) | ||
); | ||
|
||
await page.goto('/users'); | ||
|
||
// Assert that loading text is still visible at 200ms | ||
await page.waitForTimeout(200); | ||
await expect(page.locator('text="Loading..."')).toBeVisible({ timeout: 0 }); | ||
|
||
// Assert that loading text is still visible at 400ms | ||
await page.waitForTimeout(200); | ||
await expect(page.locator('text="Loading..."')).toBeVisible({ timeout: 0 }); | ||
|
||
// Assert that the query has resolved by the 600ms mark (> 500ms delay) | ||
await page.waitForTimeout(200); | ||
await expect(page.locator('text="Delayed Response"')).toBeVisible({ | ||
timeout: 0, | ||
}); | ||
}); | ||
|
||
test('should send mock response straight away if no delay has been specified in the handler', async ({ | ||
page, | ||
worker, | ||
}) => { | ||
await worker.use( | ||
rest.get('/api/users', (_, response, context) => | ||
response( | ||
context.json([ | ||
{ | ||
id: 'fake', | ||
firstName: 'Instant', | ||
lastName: 'Response', | ||
}, | ||
]) | ||
) | ||
) | ||
); | ||
|
||
await page.goto('/users'); | ||
|
||
// wait a little bit just to make sure DOM has had time to update | ||
await page.waitForTimeout(10); | ||
await expect(page.locator('text="Instant Response"')).toBeVisible({ | ||
timeout: 0, | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe one of the
waitUntil
option onpage.goto
would suffice?https://playwright.dev/docs/api/class-page#page-goto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I didn't know about this. I've updated the test to use it :)