Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI builds on Windows using Visual Studio 2017 #1691

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

mloskot
Copy link
Collaborator

@mloskot mloskot commented Jan 21, 2019

Add complete configuration files for AppVeyor and Azure Pipelines.

Tasklist

  • Review - you must request approval to merge any PR to master
  • Configure AppVeyor service for Valhalla using the supplied .appveyor.yml
  • Configure Azure Pipelines service for Valhalla using the supplied .azure-pipelines.yml
  • Add build status badges to README.md from the configured services (for valhalla/valhalla, not mloskot/valhalla, of course)

Requirements / Relations

Build Dependencies

Both configurations provided in this PR install minimum dependencies required to build the library.
Both install dependencies using https://github.com/Microsoft/vcpkg

The AppVeyor is a bit faster because it uses caches C:\Tools\vcpkg with upgraded vcpkg and the installed dependencies, so subsequent builds just restore it from the cache, instead of rebuilding.
The AppVeyor cache is invalidated if CMakeLists.txt or .appveyor.yml changes.

Build Status

The configuration has been verified on both, AppVeyor and Azure Pipelines, using my fork https://github.com/mloskot/valhalla

  • Build status

  • Build Status

UPDATE 2019-10-04: I have updated my private AzP setup
No idea why the Azure Pipelines badge says "never built" while the two builds succeeded there.
It updates fine for two AP-enabled repos I maintain, https://github.com/mloskot/ci-test and https://github.com/boostorg/gil, so it must be some temporary issue. It's minor, we will sort it out as we go :)

Setting up CI services

@kevinkreiser If you approve this PR and commit as it is without setting the services, nothing will happen. That is, the .yml files can live in the repo anyway.

To setup the services to do the builds, it takes being a member of https://github.com/valhalla/valhalla/ developers, then:

If you will need help with setting up the services, let me know.

Add complete configuration files for AppVeyor and Azure Pipelines.
@mloskot mloskot mentioned this pull request Jan 21, 2019
Copy link
Member

@kevinkreiser kevinkreiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see about enabling CI this week, amazing work @mloskot!

@kevinkreiser kevinkreiser merged commit ab6e86a into valhalla:master Jan 21, 2019
@mloskot mloskot deleted the ml/ci-windows-builds branch January 21, 2019 14:29
@mloskot
Copy link
Collaborator Author

mloskot commented Oct 4, 2019

I've re-enabled builds on Azure Pipelines for my fork, it's all as green as the AppVeyor's
https://dev.azure.com/mloskot/valhalla/_build/results?buildId=473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants