-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cardinal direction fix #1741
Merged
Merged
Cardinal direction fix #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orward and reverse refs in relations.
…n of the edge (e.g. forward and reverse ref - directionals). Fix formatting. Had to update the AddEdgeInfo methods to accept a flag that forces adding a new EdgeInfo (even if the nodes and edge Id/hash match).
…edgeinfo offset (and end node is the same tile).
…o cardinal_direction
dgearhart
reviewed
Mar 13, 2019
dgearhart
reviewed
Mar 13, 2019
dgearhart
previously approved these changes
Mar 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need to update changelog - otherwise 👍
dgearhart
approved these changes
Mar 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix highway directional for singly digitized roads and for some cases on doubly digitized ways where a relation has a direction. This required changes to OSM parsing logic to handle the forward and backward direction and dding reverse way refs to OSMData.
When a singlely digitized edge has a forward and backward direction for the reference/relation the code that builds EdgeInfo (within Graphbuilder as well as Hierarchy and Shortcut builders) has to check if a different name occurs in opposing directions of an edge. If so, then when creating EdgeInfo a new EdgeInfo is forced to be created so that different names can be supported. This creates some extra duplication of shape, but the total increase in tile sizes for North America is modest.
Testing of route differences was performed (specifically using the highway cardinal direction routes).
Example 1
Example 2