Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin name change #1853

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Admin name change #1853

merged 3 commits into from
Jun 18, 2019

Conversation

gknisely
Copy link
Member

@gknisely gknisely commented Jun 18, 2019 •
edited
Loading

Issue

United States of America was changed to United States and The Netherlands was changed to Netherlands in OSM for the country polygon.

Tasklist

  • Review - you must request approval to merge any PR to master
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Fixes #1708
Ref #1854

@gknisely gknisely requested a review from dgearhart June 18, 2019 17:47
@gknisely gknisely self-assigned this Jun 18, 2019
@gknisely gknisely mentioned this pull request Jun 18, 2019
Open
dgearhart
dgearhart approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@dgearhart dgearhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gknisely gknisely merged commit 6cb41de into master Jun 18, 2019
@purew purew deleted the admin_name_change branch February 13, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgearhart dgearhart dgearhart approved these changes

Assignees

@gknisely gknisely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

valhalla_build_admins
2 participants
@gknisely @dgearhart