map matching lazy shape and disallowed edge fix #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkreiser
commented
Jul 15, 2019
| // project a onto b where b is the origin vector representing this segment | ||
| // and a is the origin vector to the point we are projecting, (a.b/b.b)*b | ||
| const auto& u = shape[i]; | ||
| const auto& v = shape[i + 1]; | ||
| auto v = shape.pop(); |
There was a problem hiding this comment.
we decode one point at a time and completely avoid any allocations for shape decoding this gives decent speed up in loki and should do here as well (especially where we do many more checks with lots more input)
kevinkreiser
commented
Jul 15, 2019
kevinkreiser
commented
Jul 15, 2019
| @@ -162,7 +162,8 @@ inline bool IsEdgeAllowed(const baldr::DirectedEdge* edge, | |||
| const sif::cost_ptr_t& costing, | |||
| const Label& pred_edgelabel, | |||
| const baldr::GraphTile* tile) { | |||
| return !pred_edgelabel.edgeid().Is_Valid() || edgeid == pred_edgelabel.edgeid() || | |||
| return (!pred_edgelabel.edgeid().Is_Valid() && costing->GetEdgeFilter()(edge) != 0.f) || | |||
There was a problem hiding this comment.
this is the important bug fix, previously this said, whatever edge the routing sees, its allowed so long as its at the beginning of the route. this allowed the route to actually start and end on an inaccesable edge and give a route the wrong way on a one way. now if we dont have a predecessor then we'll grab the edge filter and make sure the edge is at least allowed regardless of predecessor.
dnesbitt61
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are two things going on here. the first thing is that during candidate search we use
lazy_shapeinstead ofshapeto save allocations when doing edge snapping in meili now. this is a mirror of what we do in loki and has a nice performance benefit.the more important thing here is that we fixed a pretty big bug. when we did the refactor to use the regular
Allowedmethod on the costing we had to worry about case of the first edge where we didnt have a predecessor. To work around that we apparently just said its allowed if it doesnt have a predecessor. That sucks because it leads to a situation where you can go the wrong way down a one way road if the match starts on that road. So now we use the edge filter on the first edge to remove edges that cant possibly be used by the routing algorithm.