Removed destination_only when reclassifying ferries #1905
Conversation
| if (w.destination_only() || | ||
| (w.use() != baldr::Use::kOther && | ||
| static_cast<int>(w.use()) > static_cast<int>(baldr::Use::kTurnChannel))) { | ||
| if (w.use() != baldr::Use::kOther && |
There was a problem hiding this comment.
im wondering about this. @dnesbitt61 perhaps the correct fix is to, if we detected that while updating edges we werent able to get back to a high class road, we need to do another pass where we allow the use of destination only edges?
There was a problem hiding this comment.
ok talked this over with @dnesbitt61. instead of allowing use of destination_only what we can do here is penalize it with like a 5-10 minute penalty in the cost below. this should allow us to most of the time avoid destination only expect when it is necessary.
There was a problem hiding this comment.
note that there is a break in the method once n exceeds 400. This may be too low if there is a penalty involved (may need some adjustment of this)
|
Nynähamn to Gotland: Valhalla staging (before overriding destination_only flag & before penalty added) Local valhalla (after overriding destination_only flag for ferries & adding penalty to costing) |
…only while reclassifying if the connecting edge was dest_only AND the pred was destonly, but we still untag ANY destonly if it showed up in the final upclassified path; the main change is: also remove the connecting edge's destonly, which #1905 was missing; also fix a bug in forming the upclassified path where the initial label index could be wrong
* implement a fix for destonly edges around ferries, including the ability to not un-tag destonly edges further away from ferries, i.e. where there was a break to destonly continuity * changelog * new changelog block.. * revert most of the previous changes: we only don't penalize any dest_only while reclassifying if the connecting edge was dest_only AND the pred was destonly, but we still untag ANY destonly if it showed up in the final upclassified path; the main change is: also remove the connecting edge's destonly, which #1905 was missing; also fix a bug in forming the upclassified path where the initial label index could be wrong
Issue
This PR fixes #1889
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?