Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for date_time in mapmatching across multiple legs and multipl… #2107

Merged
merged 3 commits into from
Dec 9, 2019
Merged

Account for date_time in mapmatching across multiple legs and multipl… #2107

merged 3 commits into from
Dec 9, 2019

Conversation

danpaz
Copy link
Collaborator

@danpaz danpaz commented Dec 8, 2019

Issue

Propagates and offsets the datetime information to each leg of the mapmatch.

This is just #2092 rebased on top of #2101 to make merging to master easier.

Tasklist

  • Add tests
  • Review - you must request approval to merge any PR to master
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog
  • Update relevant documentation

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@danpaz @yuzheyan
Account for date_time in mapmatching across multiple legs and multipl…
177b7bc 
…e routes

Co-authored-by: Yuzhe Yan <yuzhe.yan@mapbox.com>
yuzheyan
yuzheyan approved these changes Dec 8, 2019
View reviewed changes
Copy link
Contributor

@yuzheyan yuzheyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your hard work.

@danpaz danpaz merged commit 04c77c3 into breakfix_elapsed_time Dec 9, 2019
@kevinkreiser kevinkreiser deleted the mm_datetime branch April 12, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzheyan yuzheyan yuzheyan approved these changes

@kevinkreiser kevinkreiser Awaiting requested review from kevinkreiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danpaz @yuzheyan @kevinkreiser