Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tc internal #2173

Merged
merged 10 commits into from
Jan 21, 2020
Merged

Tc internal #2173

merged 10 commits into from
Jan 21, 2020

Conversation

gknisely
Copy link
Member

@gknisely gknisely commented Jan 21, 2020 •
edited
Loading

Issue

This PR allows more options for the processing of data. We can now turn on or off the processing of
apply_country_overrides, infer_internal_intersections, and infer_turn_channels. A placeholder has been created for use_admin_db, but the logic has not been added yet.

Note some config changes:

"data_processing": {
      "apply_country_overrides": true,
      "infer_internal_intersections": true,
      "infer_turn_channels": true,
      "use_admin_db": true
    },

Tasklist

  • Add tests
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

dgearhart
dgearhart approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@dgearhart dgearhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass 🚢

@purew purew merged commit a4dfec8 into master Jan 21, 2020
@purew purew deleted the tc_internal branch January 21, 2020 17:24
yuzheyan added a commit that referenced this pull request Jan 21, 2020
@yuzheyan
Merge branch 'master' into no_route
79e782e 
* master:
  Tc internal (#2173)
  Update README.md (#2166)
  Nit: Fixes typo icp -> ipc
  Handle large osmid better for x86 (#2161)
  Fix breakage of batch.sh for Linux
  nit: Removes need to call set_via_count explicitly
  Update README.md macos build instructions
  Fixes to make batch.sh run correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purew purew purew left review comments

@dgearhart dgearhart dgearhart approved these changes

@danpaz danpaz Awaiting requested review from danpaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gknisely @purew @dgearhart