Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Use for Rail Ferry #2408

Merged
merged 5 commits into from
Jun 5, 2020
Merged

Added Use for Rail Ferry #2408

merged 5 commits into from
Jun 5, 2020

Conversation

kdiluca
Copy link
Member

@kdiluca kdiluca commented Jun 5, 2020

Issue

This PR adds a new rail ferry use and costing.

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@kdiluca kdiluca requested a review from gknisely June 5, 2020 01:16
@kdiluca kdiluca self-assigned this Jun 5, 2020
@@ -104,6 +104,8 @@ message CostingOptions {
optional FilterAction filter_route_action = 53;
repeated string filter_route_ids = 54;
optional uint32 flow_mask = 55;
optional float railferry_cost = 56;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be rail_ferry_cost to keep the naming consistent

@kdiluca
Copy link
Member Author

kdiluca commented Jun 5, 2020

use_rail_ferry = 0
image
use_rail_ferry = 1
image

use_ferry = 0
image

use_ferry = 1
image

@kdiluca kdiluca merged commit c0b527c into master Jun 5, 2020
@nilsnolde nilsnolde deleted the kdiluca-rail_ferry branch February 24, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants