Fix mismatch of triplegedge roadclass and directededge roadclass #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkreiser
previously approved these changes
Jul 30, 2020
danpaz
force-pushed
the
fix_intersection_classes
branch
from
a6eaee6
to
88e2955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Previously in #2279, we introduced a workaround to try to undo reclassification of motorway links in triplegbuilder. As a result of this change, the road_class on directededge and tripleg_edge no longer match in the case of motorway links.
This PR essentially reverts #2279 and accepts the original issue that ReclassifyLinks will change the road class tagged in OSM. At least though we'll have consistency within the router in terms of what class each edge was considered to be during pathfinding.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?