Update intersection classes in osrm response to not label all ramps as motorway #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkreiser
previously approved these changes
Mar 19, 2020
…to motorway if an adjacent edge is a motorway
danpaz
force-pushed
the
fix_motorway_classes
branch
from
43085cc
to
f7b9f21
Compare
kevinkreiser
approved these changes
Mar 23, 2020
yuzheyan
added a commit
that referenced
this pull request
Mar 25, 2020
* master: additional data processing options (#2285) Fix Uturn cases on not_thru edge connected to origin. (#2272) Interpolation bug fix (#2275) Update intersection classes in osrm response to not label all ramps as motorway (#2279) More stop impact changes (#2282) Fixed verbal multi-cue logic (#2270) Re-write test/astar.cc to use gurka graph creation helpers rather than hard-coding edge creation/IDs Add gurka test framework to ease creation of test cases with ascii-maps Add helper functions so that we can perform actions without serializing if desired - this is to support testing of intermediate results. Make protobuf cleanup after tile building optional (on by default) so that tests can repeatedly call mjolnir::build_tile_set Downgrade some log messages to warnings - they are non-fatal behaviours, no error is actually emitted by the code. Reduce concurrency of lint debug build so that it doesn't hit OOM problems on CI Exact Reachability (ie v3) (#2243)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Pulling just the minimal fix out of #2276 for the
intersections.classes[]part of the response. After discussing with @kevinkreiser adding road_class to waypoints will need more work to keep track of which edge along the path is associated with each location.Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?