Update visual compare script #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sif/autocost.cc
Outdated
| @@ -46,7 +46,7 @@ constexpr float kDefaultUseRailFerry = 0.4f; // Default preference of using a ra | |||
| constexpr float kDefaultUseHighways = 1.0f; // Default preference of using a motorway or trunk 0-1 | |||
| constexpr float kDefaultUseTolls = 0.5f; // Default preference of using toll roads 0-1 | |||
| constexpr float kDefaultUseTracks = 0.f; // Default preference of using tracks 0-1 | |||
| constexpr float kDefaultUseDistance = 0.f; // Default preference of using distance vs time 0-1 | |||
| constexpr float kDefaultUseDistance = 0.5f; // Default preference of using distance vs time 0-1 | |||
There was a problem hiding this comment.
Dumb q, but wouldn't 0.5 indicate equal preference to both?
|
Thanks for making the visual-diff tool! Those before-after paths really show the difference the weightage is making to path selection! |
dgearhart
changed the title
…_default_time_v_dist
|
We will have to revisit when we have more time |
gknisely
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to change the default preference between time and distance in
AutoCost. At the moment the default is to prefer above all else the shortest time route (barring other attirbute based penalties). This can lead to routes that stick very heavily to highways or higher class roads at the expense of taking a much more direct path to the destiation. I'll update this description with as many anecdotal changes as I can to give a flavor of what this change does in practice.In addition to that change I wrote a small script that can use the differences found in RAD to generate urls for viewing the route paths on the same map. This makes use of the tool i made in: valhalla/demos#236
On to the visual diffs (the script makes the previous route red and the new route green):