Fix costing enum for avoids in loki #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpat
approved these changes
Feb 10, 2021
|
🤦 |
| @@ -94,7 +94,7 @@ void loki_worker_t::parse_costing(Api& api, bool allow_none) { | |||
| auto avoid_locations = PathLocation::fromPBF(options.avoid_locations()); | |||
| auto results = loki::Search(avoid_locations, *reader, costing); | |||
| std::unordered_set<uint64_t> avoids; | |||
| auto* co = options.mutable_costing_options(static_cast<uint8_t>(costing->travel_mode())); | |||
There was a problem hiding this comment.
yeah this is easy to confuse with mode costing which has a costing object per mode of travel (for multimodal). tbh i started working on a refactor of all of this stuff to make it less confusing but i never got it finished. we kind of made a mistake in the original api design that forced us into multimodal making everything miserable for us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2853
"by accident" car and bike worked out, all the other profiles not so much..